[Fix][Valve] Move DefaultOpenDuration constraint handling out of IDM_9_1 test module PR (project-chip#43715)

* [Fix][Valve] Move DefaultOpenDuration constraint handling out of IDM_9_1 test module PR

* Fix DefaultOpenDuration nullable persistence encoding

---------

Co-authored-by: C Freeman <cecille@google.com>

Author: j-ororke

src/app/clusters/valve-configuration-and-control-server/ValveConfigurationAndControlCluster.cpp

@@ -153,8 +153,25 @@ DataModel::ActionReturnStatus ValveConfigurationAndControlCluster::WriteImpl(con
 
     if (request.path.mAttributeId == ValveConfigurationAndControl::Attributes::DefaultOpenDuration::Id)
     {
-        AttributePersistence persistence{ mContext->attributeStorage };
-        return persistence.DecodeAndStoreNativeEndianValue(request.path, decoder, mDefaultOpenDuration);
+        DataModel::Nullable<uint32_t> value;
+        ReturnErrorOnFailure(decoder.Decode(value));
+
+        // DefaultOpenDuration has a constraint: min value = 1 (when not null)
+        if (!value.IsNull() && value.Value() < 1)
+        {
+            return CHIP_IM_GLOBAL_STATUS(ConstraintError);
+        }
+
+        // Avoid rewriting storage if unchanged
+        VerifyOrReturnValue(value != mDefaultOpenDuration, DataModel::ActionReturnStatus::FixedStatus::kWriteSuccessNoOp);
+
+        mDefaultOpenDuration = value;
+
+        // Persist using AttributePersistence nullable storage representation.
+        NumericAttributeTraits<uint32_t>::StorageType storageValue;
+        NullableToStorage(mDefaultOpenDuration, storageValue);
+        return mContext->attributeStorage.WriteValue(request.path,
+                                                     { reinterpret_cast<const uint8_t *>(&storageValue), sizeof(storageValue) });
     }
 
     if (request.path.mAttributeId == ValveConfigurationAndControl::Attributes::DefaultOpenLevel::Id)