iOS: new arch: serveral zoom depending bugs

[cixio]

Describe the bug

• pinch to zoom does not work (zoomMode)
• set a zoom value does not work (zoom)
• when using new arch the module uses the wide-angle-camera (0,5x zoom in camera app) at first, in old arch the normal-view-camera (1x zoom in camera app)

To Reproduce
Create App with new arch. To force use of old arch (to see differnces) add ENV['RCT_NEW_ARCH_ENABLED'] = "0" to the first line of Podfile, pod install and run app

Expected behavior
zoomMode + zoom should work, view should be the same on startup

Screenshots

Smartphone (please complete the following information):

• Device: iPhone 14 Pro
• OS: iOS 18.1

react-native-camera-kit v14.1

[cixio]

Updated first comment and title as zoom functions do not work at all in new arch.

[cixio]

Maybe this line is part of the problem

react-native-camera-kit/ios/ReactNativeCameraKit/CKCameraViewComponentView.mm

Line 225 in 55bdd97

_view.zoomMode = [focusMode isEqualToString:@"on"] ? CKZoomModeOn : CKZoomModeOff;

_view.zoomMode = [focusMode isEqualToString:@"on"] ? CKZoomModeOn : CKZoomModeOff;

focusMode seems to be wrong in this line. But fixing this does not solve the problems - at least not the way I tried.

[DavidBertet]

This is because when we set onZoom in the new CKCameraViewComponentView, we aren't adding it in the changedProps

react-native-camera-kit/ios/ReactNativeCameraKit/CKCameraViewComponentView.mm

Lines 110 to 117 in 55bdd97

	[_view setOnZoom:^(NSDictionary* event) {
	__typeof__(self) strongSelf = weakSelf;
	if (strongSelf != nullptr && strongSelf->_eventEmitter != nullptr) {
	id zoom = [event valueForKey:@"zoom"] == nil ? 0 : [event valueForKey:@"zoom"];
	std::dynamic_pointer_cast<const facebook::react::CKCameraEventEmitter>(strongSelf->_eventEmitter)->onZoom({.zoom = [zoom doubleValue]});
	}
	}];

So cameraView never forwards it to the actual camera implementation

react-native-camera-kit/ios/ReactNativeCameraKit/CameraView.swift

Lines 196 to 198 in 55bdd97

	if changedProps.contains("onZoom") {
	camera.update(onZoom: onZoom)
	}

Hence, when we call onZoom after a pinch, it is nil

react-native-camera-kit/ios/ReactNativeCameraKit/RealCamera.swift

Line 193 in 55bdd97

self.onZoomCallback?(["zoom": desiredOrCameraZoom])

react-native-camera-kit/ios/ReactNativeCameraKit/SimulatorCamera.swift

Line 97 in 55bdd97

self.onZoom?(["zoom": zoomForDevice])

@WoLewicki, we might want to split cameraView prop management in 2 methods like the new CKCameraViewComponentView

• One that manages callbacks props. These are set once at the init and can't be updated
• One the manages variable props. These can be update during the life of the view

[WoLewicki]

Thanks for researching it @DavidBertet ! Would you like to take care of it?

[DavidBertet]

Thanks for researching it @DavidBertet ! Would you like to take care of it?

Unfortunately I don’t have the time to test it properly, but would happily review a PR

[cixio]

Hey @WoLewicki @DavidBertet, could one of you take a deeper look at this issue? It's the last missing piece we need to update to Fabric.

I've spent a few hours on it already, but since I'm not familiar with Swift, I can't quite figure out what’s going wrong. I've received some helpful advice here, but I don’t fully understand it. I might be able to fix it with a few more hints.

Would really appreciate your help on this!

[WilliamWelsh]

Still an issue in the latest version, iPhone is forced to use the wide angle lens...

[WilliamWelsh]

Pretty sure this is supposed to be zoomMode and not focusMode

https://github.com/teslamotors/react-native-camera-kit/blob/master/ios/ReactNativeCameraKit/CKCameraViewComponentView.mm#L225-L229

Edit: Fixed in #728

[cixio]

@WilliamWelsh look above: #691 (comment)

[zedtux]

Is there any news regarding this issue?

[WilliamWelsh]

Is there any news regarding this issue?

I ended up switching to react-native-vision-camera since I need to be on new arch, only downside is there is no simulator support, but the 60fps stream is nice

[zedtux]

Is there any news regarding this issue?

I ended up switching to react-native-vision-camera since I need to be on new arch, only downside is there is no simulator support, but the 60fps stream is nice

Thank you for your update, but I want to stick on this library.