fix(clouds): coerce mapped OpenStack config values to strings

YAML parsing can return non-string scalars (for example identity_api_version: 3
-> Integer).

fog-openstack expects several auth/config fields as strings and calls regex
matching on openstack_identity_api_version, which raised undefined method '=~'
for Integer during authentication.

Normalize all clouds.yaml and OS_* mapped keys in CLOUDS_YAML_AUTH_MAP and
CLOUDS_YAML_TOP_MAP to strings before passing them into Fog.

Add regression coverage to ensure numeric YAML scalars are coerced for
openstack_project_id, openstack_domain_id, and openstack_identity_api_version.

Signed-off-by: Lance Albertson <lance@osuosl.org>

Author: ramereth

lib/kitchen/driver/openstack/clouds.rb

@@ -48,6 +48,10 @@ module Clouds
           "identity_api_version" => :openstack_identity_api_version,
         }.freeze
 
+        # Fog expects these config values to be strings. YAML may parse
+        # unquoted scalars as integers/booleans, so normalize on ingest.
+        STRING_CONFIG_KEYS = (CLOUDS_YAML_AUTH_MAP.values + CLOUDS_YAML_TOP_MAP.values).freeze
+
         # Mapping of OS_* environment variables to Fog OpenStack config keys
         ENV_VAR_MAP = {
           "OS_AUTH_URL" => :openstack_auth_url,
@@ -100,7 +104,7 @@ def load_env_vars
           result = {}
           ENV_VAR_MAP.each do |env_var, fog_key|
             value = ENV[env_var]
-            result[fog_key] = value if value && !value.empty?
+            result[fog_key] = normalize_config_value(fog_key, value) if value && !value.empty?
           end
           result
         end
@@ -175,12 +179,14 @@ def translate_cloud_config(cloud)
           # Map auth section
           auth = cloud["auth"] || {}
           CLOUDS_YAML_AUTH_MAP.each do |yaml_key, fog_key|
-            result[fog_key] = auth[yaml_key] if auth[yaml_key]
+            value = auth[yaml_key]
+            result[fog_key] = normalize_config_value(fog_key, value) if value
           end
 
           # Map top-level keys
           CLOUDS_YAML_TOP_MAP.each do |yaml_key, fog_key|
-            result[fog_key] = cloud[yaml_key] if cloud[yaml_key]
+            value = cloud[yaml_key]
+            result[fog_key] = normalize_config_value(fog_key, value) if value
           end
 
           # SSL settings
@@ -189,6 +195,12 @@ def translate_cloud_config(cloud)
 
           result
         end
+
+        def normalize_config_value(fog_key, value)
+          return value unless STRING_CONFIG_KEYS.include?(fog_key)
+
+          value.to_s
+        end
       end
     end
   end

spec/kitchen/driver/openstack/clouds_spec.rb

@@ -384,6 +384,21 @@
       result = driver.send(:translate_cloud_config, {})
       expect(result).to eq({})
     end
+
+    it "coerces non-string scalar values for fog string config keys" do
+      cloud = {
+        "auth" => {
+          "project_id" => 12_345,
+          "domain_id" => 9,
+        },
+        "identity_api_version" => 3,
+      }
+
+      result = driver.send(:translate_cloud_config, cloud)
+      expect(result[:openstack_project_id]).to eq("12345")
+      expect(result[:openstack_domain_id]).to eq("9")
+      expect(result[:openstack_identity_api_version]).to eq("3")
+    end
   end
 
   describe "#deep_merge" do