adding more checks to avoid abrupt reload and triggering browser tab failure and reload

Author: Shriyansh Agnihotri

testzeus_hercules/core/playwright_manager.py

@@ -975,6 +975,7 @@ async def go_to_homepage(self) -> None:
 
     async def set_navigation_handler(self) -> None:
         page: Page = await self.get_current_page()
+        await page.wait_for_load_state("domcontentloaded")
         page.on("domcontentloaded", handle_navigation_for_mutation_observer)
 
         async def set_iframe_navigation_handlers() -> None:
@@ -1856,6 +1857,13 @@ async def reuse_or_create_tab(self, force_new_tab: bool = False) -> Page:
         # Try to reuse existing tab (use the most recent one)
         page = pages[-1]  # The most recently used page
 
+        try:
+            await page.wait_for_load_state("networkidle", timeout=5000)
+        except Exception as e:
+            logger.warning(f"Failed to wait for networkidle: {e}")
+        finally:
+            await page.wait_for_load_state("domcontentloaded")
+
         # Check if the page is responsive, with a shorter timeout to avoid hanging
         try:
             # Simple check (the timeout is applied at a higher level)
@@ -1881,6 +1889,7 @@ async def reuse_or_create_tab(self, force_new_tab: bool = False) -> Page:
             for i in range(len(pages) - 2, -1, -1):
                 try:
                     page = pages[i]
+                    await page.wait_for_load_state("domcontentloaded")
                     await page.evaluate("1")
                     logger.info(f"Reusing alternative tab with URL: {page.url}")
 

testzeus_hercules/core/tools/open_url.py

@@ -24,6 +24,7 @@ async def openurl(
     timeout: Annotated[int, "Additional wait time in seconds after initial load."] = 3,
     force_new_tab: Annotated[bool, "Force opening in a new tab instead of reusing existing ones."] = False,
 ) -> Annotated[str, "Returns the result of this request in text form"]:
+
     logger.info(f"Opening URL: {url} (force_new_tab={force_new_tab})")
     browser_manager = PlaywrightManager()
     await browser_manager.get_browser_context()