Consider making a copy of request and response

[dnperfors]

Is your feature request related to a problem? Please describe.
Currently a reference to the original request and response is made, this will break assertion when the request/response is being disposed before the assertion is made.

Describe the solution you'd like
A copy of the complete request and response could be made in order to be able to assert after the request/response are disposed.

[dnperfors]

This might not be that easy to accomplish, since there are multiple options this can be done:

1. Clone the HttpRequestMessage using HttpRequestMessage.
2. Make a TestableHttpClient specific version of the Request.

Both have there pro's and con's, which I will detail here for future reference.

Clone the HttpRequestMessage using HttpRequestMessage.

This solution basically uses a await request.CloneAsync() to create a clone. The original HttpRequestMessage can then be disposed.

Pros

• Minimal code changes: possibly only the TestableHttpHandler has to be changed.
• Backwards compatible: Basically all the existing methods will keep working without change, so will the tests.
• Consumers will not need any changes.

Cons

• It will not be easier to simplify the assertions and error messages

Custom Request class

This solution would provide a custom class or record that holds all the information of the Request.

Pros

• Will make simplifying assertions and error messages easier

Cons

• A lot of code needs to be changed
• A big breaking change: a lot of code needs to change in order to get this working

Conclusion

Despite the disadvantages, I really like the second option more than the first option. However, the first option is simpler to implement, with less risk of failing the implementation.
Therefor I will implement the first option and after release start investigating the second option to be a basis for improved error messages and assertions.

[dnperfors]

Implemented by #317
By cloning the HttpRequestMessage, the issues around dispose are solved.