Skip to content

Commit a5d45f8

Browse files
committed
fix(#634): JsonReaderException in Docker.DotNet with Docker Desktop 4.13.0
1 parent 48fa89f commit a5d45f8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
- 604 Do not deny all files in the Docker image tarball when a `.dockerignore` entry ends with `/`
3737
- 610 Do not deny all files in the Docker image tarball when a `.dockerignore` entry ends with `/*`
3838
- 632 Execute local database scripts (inside the container) against `localhost`
39+
- 634 JsonReaderException in Docker.DotNet with Docker Desktop 4.13.0 (https://github.com/dotnet/Docker.DotNet/issues/595)
3940

4041
## [2.1.0]
4142

src/Testcontainers/Clients/DockerImageOperations.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ public async Task CreateAsync(IDockerImage image, IDockerRegistryAuthenticationC
6464
{
6565
var createParameters = new ImagesCreateParameters
6666
{
67-
FromImage = image.FullName,
67+
FromImage = image.FullName.Replace(":" + image.Tag, string.Empty), // Workaround until https://github.com/dotnet/Docker.DotNet/issues/595 is fixed.
68+
Tag = image.Tag,
6869
};
6970

7071
var authConfig = new AuthConfig

0 commit comments

Comments
 (0)