fix(#634): JsonReaderException in Docker.DotNet with Docker Desktop 4…

….13.0
testcontainers · Oct 24, 2022 · a5d45f8 · a5d45f8
1 parent 48fa89f
commit a5d45f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@
 - 604 Do not deny all files in the Docker image tarball when a `.dockerignore` entry ends with `/`
 - 610 Do not deny all files in the Docker image tarball when a `.dockerignore` entry ends with `/*`
 - 632 Execute local database scripts (inside the container) against `localhost`
+- 634 JsonReaderException in Docker.DotNet with Docker Desktop 4.13.0 (https://github.com/dotnet/Docker.DotNet/issues/595)
 
 ## [2.1.0]
 

diff --git a/src/Testcontainers/Clients/DockerImageOperations.cs b/src/Testcontainers/Clients/DockerImageOperations.cs
@@ -64,7 +64,8 @@ public async Task CreateAsync(IDockerImage image, IDockerRegistryAuthenticationC
     {
       var createParameters = new ImagesCreateParameters
       {
-        FromImage = image.FullName,
+        FromImage = image.FullName.Replace(":" + image.Tag, string.Empty), // Workaround until https://github.com/dotnet/Docker.DotNet/issues/595 is fixed.
+        Tag = image.Tag,
       };
 
       var authConfig = new AuthConfig