From 4535d105fc09678c1817882a0d4b124c581fe0aa Mon Sep 17 00:00:00 2001 From: Riva Junior Date: Tue, 26 Sep 2023 22:21:28 -0300 Subject: [PATCH 1/3] chore: remove duplicated eslintConfig --- .eslintignore | 3 +++ package.json | 13 ------------- 2 files changed, 3 insertions(+), 13 deletions(-) create mode 100644 .eslintignore diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 0000000..9c62828 --- /dev/null +++ b/.eslintignore @@ -0,0 +1,3 @@ +node_modules +coverage +dist diff --git a/package.json b/package.json index 309516f..62eac67 100644 --- a/package.json +++ b/package.json @@ -52,19 +52,6 @@ "peerDependencies": { "cypress": "^12.0.0 || ^13.0.0" }, - "eslintConfig": { - "extends": "./node_modules/kcd-scripts/eslint.js", - "rules": { - "import/prefer-default-export": "off", - "import/no-unassigned-import": "off", - "jest/valid-expect": "off" - } - }, - "eslintIgnore": [ - "node_modules", - "coverage", - "dist" - ], "repository": { "type": "git", "url": "https://github.com/kentcdodds/cypress-testing-library" From ddc7f478f9c99186a8c5e4000af75c0d3eef9476 Mon Sep 17 00:00:00 2001 From: Riva Junior Date: Tue, 26 Sep 2023 22:22:25 -0300 Subject: [PATCH 2/3] chore: add pnpm-lock.yaml to gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index dd6ebe2..10c5744 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ dist # when working with contributors package-lock.json yarn.lock +pnpm-lock.yaml # cypress recordings during a test run are temporary files /cypress/videos/ From 7ed89fbd9eccac7e9890c63bae1e32c06b32f974 Mon Sep 17 00:00:00 2001 From: Riva Junior Date: Tue, 26 Sep 2023 22:23:02 -0300 Subject: [PATCH 3/3] chore: rename eslint config file Use the recommended filename with extension --- .eslintrc | 9 --------- .eslintrc.js | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-) delete mode 100644 .eslintrc create mode 100644 .eslintrc.js diff --git a/.eslintrc b/.eslintrc deleted file mode 100644 index 662e597..0000000 --- a/.eslintrc +++ /dev/null @@ -1,9 +0,0 @@ -{ - "extends": "./node_modules/kcd-scripts/eslint.js", - "rules": { - "max-lines-per-function": "off", - "testing-library/prefer-screen-queries": "off", - "testing-library/no-dom-import": "off", // We're not using React Testing Library here. We're wrapping DOM Testing Library directly - "@typescript-eslint/no-explicit-any": "off" // let's do better in the future - } -} diff --git a/.eslintrc.js b/.eslintrc.js new file mode 100644 index 0000000..fa524c1 --- /dev/null +++ b/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + extends: './node_modules/kcd-scripts/eslint.js', + rules: { + 'max-lines-per-function': 'off', + 'testing-library/prefer-screen-queries': 'off', + 'testing-library/no-dom-import': 'off', // We're not using React Testing Library here. We're wrapping DOM Testing Library directly + '@typescript-eslint/no-explicit-any': 'off', // let's do better in the future + }, +}