Skip to content

Commit 29a17cb

Browse files
authored
fix: load and error dispatch Event instead of UIEvent (#1147)
1 parent 54bfa48 commit 29a17cb

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

src/__tests__/events.js

+10-5
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,16 @@ const eventTypes = [
7171
events: ['scroll'],
7272
elementType: 'div',
7373
},
74+
{
75+
type: '',
76+
events: ['load', 'error'],
77+
elementType: 'img',
78+
},
79+
{
80+
type: '',
81+
events: ['load', 'error'],
82+
elementType: 'script',
83+
},
7484
{
7585
type: 'Wheel',
7686
events: ['wheel'],
@@ -105,11 +115,6 @@ const eventTypes = [
105115
],
106116
elementType: 'video',
107117
},
108-
{
109-
type: 'Image',
110-
events: ['load', 'error'],
111-
elementType: 'img',
112-
},
113118
{
114119
type: 'Animation',
115120
events: ['animationStart', 'animationEnd', 'animationIteration'],

src/event-map.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,13 @@ export const eventMap = {
274274
EventType: 'Event',
275275
defaultInit: {bubbles: false, cancelable: false},
276276
},
277-
// Image Events
277+
// Events
278278
load: {
279-
EventType: 'UIEvent',
279+
// TODO: load events can be UIEvent or Event depending on what generated them
280+
// This is were this abstraction breaks down.
281+
// But the common targets are <img />, <script /> and window.
282+
// Neither of these targets receive a UIEvent
283+
EventType: 'Event',
280284
defaultInit: {bubbles: false, cancelable: false},
281285
},
282286
error: {

0 commit comments

Comments
 (0)