Skip to content

feat(prefer-user-event): add support for React Native events #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(prefer-user-event): add support for React Native events #958

wants to merge 2 commits into from

Conversation

ddrozdov
Copy link

@ddrozdov ddrozdov commented Nov 7, 2024

Checks

Changes

  • add support for React Native events

Context

Fixes #957

MichaelDeBoey
MichaelDeBoey reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddrozdov This plugin (currently) doesn't support @testing-library/react-native.

I'll let @Belco90 decide what to do with this, but imo we should not add this and add full support in 1 go instead

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (93a6ab9) to head (02dc49e).
Report is 67 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files          44       46       +2     
  Lines        2419     2481      +62     
  Branches     1000     1024      +24     
==========================================
+ Hits         2328     2390      +62     
  Misses         91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Belco90
Belco90 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ddrozdov! Sorry it took me so long to react to this.

I've seen there are several PRs for adding support for React Native in this plugin (this PR, #956, others in the past). Instead of having separated PRs for adding support here and there, we should unify the changes to support RN entirely in one go, similar to what was done in #973.

So we need to create an umbrella issue to gather what's missing in this plugin to fully support RN, then move the current work there, including the RN preset.

@Belco90 Belco90 mentioned this pull request Dec 5, 2024
Closed
1 task
@Belco90
Copy link
Member

Belco90 commented May 16, 2025

Closing in favor of adding React Native support properly. Added to React Native support (view) to track necessary changes.

@Belco90 Belco90 closed this May 16, 2025
@Belco90 Belco90 moved this from Done to Backlog in React Native support May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey left review comments

Assignees
No one assigned
Labels
None yet
Projects
React Native support
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support React Native events in prefer-user-event
3 participants
@ddrozdov @Belco90 @MichaelDeBoey