Skip to content

React 18 migration for waitForNextUpdate repeats steps for waitForValueToChange instead #975

Open
@sfc-gh-mgolebiowskiowczarek

Description

  • react-hooks-testing-library version: N/A
  • react version: N/A
  • react-dom version (if applicable): N/A
  • react-test-renderer version (if applicable): N/A
  • node version: N/A
  • npm (or yarn) version: N/A

Relevant code or config:

N/A

What you did:

I read https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md#waitfornextupdate (section waitForNextUpdate).

What happened:

That section shows the following code snippet:

-await waitForValueToChange(() => result.current.state);
+const initialValue = result.current;
+await waitFor(() => {
+  expect(result.current).not.toBe(initialValue);
+});

Reproduction:

N/A, this is a docs change.

Problem description:

As you can see, it actually shows the migration path for waitForValueToChange which was already handled in the previous section. The code seems erroneously repeated.

Suggested solution:

Provide a proper code migration path, where the "before" state actually uses the waitForNextUpdate API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions