From 1905b506cb9c9c6113a00e16de31e76ebee88ea0 Mon Sep 17 00:00:00 2001 From: Michael Cousins Date: Thu, 18 Apr 2024 16:08:20 -0400 Subject: [PATCH 1/4] wip: experiment with accessors --- src/__tests__/rerender.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/__tests__/rerender.test.js b/src/__tests__/rerender.test.js index ca4b8e8..477b430 100644 --- a/src/__tests__/rerender.test.js +++ b/src/__tests__/rerender.test.js @@ -44,6 +44,7 @@ describe('rerender', () => { await act(() => { component.name = 'Planet' }) + await act() expect(element).toHaveTextContent('Hello Planet!') }) From be0c84b3db8cacd748e5ab41b09a95e19b571cc5 Mon Sep 17 00:00:00 2001 From: Michael Cousins Date: Thu, 18 Apr 2024 16:44:24 -0400 Subject: [PATCH 2/4] wip: still trying stuff out --- src/__tests__/rerender.test.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/__tests__/rerender.test.js b/src/__tests__/rerender.test.js index 477b430..033c60c 100644 --- a/src/__tests__/rerender.test.js +++ b/src/__tests__/rerender.test.js @@ -1,4 +1,4 @@ -import { act, render, screen } from '@testing-library/svelte' +import { act, render, screen, waitFor } from '@testing-library/svelte' import { VERSION as SVELTE_VERSION } from 'svelte/compiler' import { describe, expect, test, vi } from 'vitest' @@ -44,8 +44,7 @@ describe('rerender', () => { await act(() => { component.name = 'Planet' }) - await act() - expect(element).toHaveTextContent('Hello Planet!') + await waitFor(() => expect(element).toHaveTextContent('Hello Planet!')) }) }) From fa7a20755733ea67f7ef7421d6c2b65a0f28f498 Mon Sep 17 00:00:00 2001 From: Michael Cousins Date: Fri, 19 Apr 2024 13:26:53 -0400 Subject: [PATCH 3/4] wip: cannot repro locally on macos, how about on CI? --- .github/workflows/release.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index be47107..321a053 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,11 +18,12 @@ jobs: # ignore all-contributors PRs if: ${{ !contains(github.head_ref, 'all-contributors') }} name: Node ${{ matrix.node }}, Svelte ${{ matrix.svelte }}, ${{ matrix.test-runner }} - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} continue-on-error: ${{ matrix.experimental }} strategy: fail-fast: false matrix: + os: ['ubuntu-latest'] node: ['16', '18', '20'] svelte: ['3', '4'] test-runner: ['vitest:jsdom', 'vitest:happy-dom'] @@ -32,10 +33,12 @@ jobs: svelte: 'next' test-runner: 'vitest:jsdom' experimental: true + os: 'macos-latest' - node: '20' svelte: 'next' test-runner: 'vitest:happy-dom' experimental: true + os: 'ubuntu-latest' steps: - name: ⬇️ Checkout repo From 5fbb8c68de84d26eb7ea8478cd59cd02c6335d92 Mon Sep 17 00:00:00 2001 From: Michael Cousins Date: Sat, 20 Apr 2024 10:48:27 -0400 Subject: [PATCH 4/4] wip: revert to check out latest prerelease --- .github/workflows/release.yml | 5 +---- src/__tests__/rerender.test.js | 4 ++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 321a053..be47107 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,12 +18,11 @@ jobs: # ignore all-contributors PRs if: ${{ !contains(github.head_ref, 'all-contributors') }} name: Node ${{ matrix.node }}, Svelte ${{ matrix.svelte }}, ${{ matrix.test-runner }} - runs-on: ${{ matrix.os }} + runs-on: ubuntu-latest continue-on-error: ${{ matrix.experimental }} strategy: fail-fast: false matrix: - os: ['ubuntu-latest'] node: ['16', '18', '20'] svelte: ['3', '4'] test-runner: ['vitest:jsdom', 'vitest:happy-dom'] @@ -33,12 +32,10 @@ jobs: svelte: 'next' test-runner: 'vitest:jsdom' experimental: true - os: 'macos-latest' - node: '20' svelte: 'next' test-runner: 'vitest:happy-dom' experimental: true - os: 'ubuntu-latest' steps: - name: ⬇️ Checkout repo diff --git a/src/__tests__/rerender.test.js b/src/__tests__/rerender.test.js index 033c60c..ca4b8e8 100644 --- a/src/__tests__/rerender.test.js +++ b/src/__tests__/rerender.test.js @@ -1,4 +1,4 @@ -import { act, render, screen, waitFor } from '@testing-library/svelte' +import { act, render, screen } from '@testing-library/svelte' import { VERSION as SVELTE_VERSION } from 'svelte/compiler' import { describe, expect, test, vi } from 'vitest' @@ -45,6 +45,6 @@ describe('rerender', () => { component.name = 'Planet' }) - await waitFor(() => expect(element).toHaveTextContent('Hello Planet!')) + expect(element).toHaveTextContent('Hello Planet!') }) })