From 5f3d28fe3a5a83b7403c1c6f41ba2be881306bfc Mon Sep 17 00:00:00 2001
From: Bryan Jensen <bryanawjensen@gmail.com>
Date: Wed, 15 Jan 2025 11:53:52 -0800
Subject: [PATCH] fix(pointer): check all fields of `PointerCoords` in
 `isDifferentPointerPosition()` (#1229)

Co-authored-by: Bryan Jensen <bryan@coda.io>
---
 src/system/pointer/shared.ts |  8 ++++++++
 tests/pointer/drag.ts        | 21 +++++++++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/src/system/pointer/shared.ts b/src/system/pointer/shared.ts
index a00bb441..afea4050 100644
--- a/src/system/pointer/shared.ts
+++ b/src/system/pointer/shared.ts
@@ -29,6 +29,14 @@ export function isDifferentPointerPosition(
     positionA.target !== positionB.target ||
     positionA.coords?.x !== positionB.coords?.x ||
     positionA.coords?.y !== positionB.coords?.y ||
+    positionA.coords?.clientX !== positionB.coords?.clientX ||
+    positionA.coords?.clientY !== positionB.coords?.clientY ||
+    positionA.coords?.offsetX !== positionB.coords?.offsetX ||
+    positionA.coords?.offsetY !== positionB.coords?.offsetY ||
+    positionA.coords?.pageX !== positionB.coords?.pageX ||
+    positionA.coords?.pageY !== positionB.coords?.pageY ||
+    positionA.coords?.screenX !== positionB.coords?.screenX ||
+    positionA.coords?.screenY !== positionB.coords?.screenY ||
     positionA.caret?.node !== positionB.caret?.node ||
     positionA.caret?.offset !== positionB.caret?.offset
   )
diff --git a/tests/pointer/drag.ts b/tests/pointer/drag.ts
index 5414369a..232cdd50 100644
--- a/tests/pointer/drag.ts
+++ b/tests/pointer/drag.ts
@@ -20,6 +20,27 @@ test('drag sequence', async () => {
   `)
 })
 
+test('drag sequence w/ differing client coordinates', async () => {
+  const {element, getClickEventsSnapshot, user} = setup(`<div></div>`)
+
+  await user.pointer([
+    {keys: '[MouseLeft>]', target: element, coords: {clientX: 0, clientY: 0}},
+    {target: element, coords: {clientX: 0, clientY: 0}}, // doesn't actually move, won't show up in snapshot below
+    {target: element, coords: {clientX: 10, clientY: 0}}, // will show up in snapshot below
+    '[/MouseLeft]',
+  ])
+
+  expect(getClickEventsSnapshot()).toMatchInlineSnapshot(`
+    pointerdown - pointerId=1; pointerType=mouse; isPrimary=true
+    mousedown - button=0; buttons=1; detail=1
+    pointermove - pointerId=1; pointerType=mouse; isPrimary=true
+    mousemove - button=0; buttons=1; detail=0
+    pointerup - pointerId=1; pointerType=mouse; isPrimary=true
+    mouseup - button=0; buttons=0; detail=1
+    click - button=0; buttons=0; detail=1
+  `)
+})
+
 test('drag touch', async () => {
   const {element, getClickEventsSnapshot, user} = setup(`<div></div>`)