Enable vulkan whispercpp (#1763)

* Make vulkan be on by default

* Resolve issues with cpp lint and cpp tests in whisper workflows

Author: GustavoA1604

.github/workflows/cpp-lint.yaml

@@ -177,7 +177,7 @@ jobs:
       - name: Generate build system
         id: bare_make_generate
         working-directory: ${{ env.WORKDIR }}
-        run: bare-make generate
+        run: bare-make generate -D ENABLE_VULKAN=OFF
 
       - name: Check C++ files format
         id: cpp_files_fmt

packages/qvac-lib-infer-whispercpp/CHANGELOG.md

@@ -5,7 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.6.4]
+
+### Changed
+- Fixed bug that prevented Vulkan from being turned on by default on linux and windows
 
 ## [0.6.3]
 

packages/qvac-lib-infer-whispercpp/CMakeLists.txt

@@ -2,7 +2,13 @@ cmake_minimum_required(VERSION 3.25)
 
 option(BUILD_TESTING "Build tests" OFF)
 
-if(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android" OR CMAKE_SYSTEM_NAME STREQUAL "Windows")
+if(DEFINED CMAKE_SYSTEM_NAME)
+  set(_qvac_whispercpp_target_os "${CMAKE_SYSTEM_NAME}")
+else()
+  set(_qvac_whispercpp_target_os "${CMAKE_HOST_SYSTEM_NAME}")
+endif()
+
+if(_qvac_whispercpp_target_os STREQUAL "Linux" OR _qvac_whispercpp_target_os STREQUAL "Android" OR _qvac_whispercpp_target_os STREQUAL "Windows")
   option(ENABLE_VULKAN "Enable Vulkan GPU acceleration" ON)
 else()
   option(ENABLE_VULKAN "Enable Vulkan GPU acceleration" OFF)

packages/qvac-lib-infer-whispercpp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@qvac/transcription-whispercpp",
-  "version": "0.6.3",
+  "version": "0.6.4",
   "description": "transcription addon for qvac",
   "addon": true,
   "engines": {
@@ -14,10 +14,10 @@
     "test:integration": "brittle-bare test/integration/addon.test.js",
     "test:benchmark:rtf": "brittle-bare test/benchmark/rtf-benchmark.test.js",
     "test:integration:long": "brittle-bare test/integration/**/longES.test.js",
-    "test:cpp:build": "bare-make generate -D BUILD_TESTING=ON && bare-make build --target test-whisper-core && bare-make install",
+    "test:cpp:build": "bare-make generate -D BUILD_TESTING=ON -D ENABLE_VULKAN=OFF && bare-make build --target test-whisper-core && bare-make install",
     "test:cpp:run": "cd build/addon/tests/ && LLVM_PROFILE_FILE=default.profraw ./test-whisper-core --gtest_output=xml:cpp-test-results.xml",
     "test:cpp": "npm run test:cpp:build && npm run test:cpp:run",
-    "coverage:cpp:build": "bare-make generate -D BUILD_TESTING=ON -D ENABLE_COVERAGE=ON && bare-make build --target test-whisper-core",
+    "coverage:cpp:build": "bare-make generate -D BUILD_TESTING=ON -D ENABLE_COVERAGE=ON -D ENABLE_VULKAN=OFF && bare-make build --target test-whisper-core",
     "coverage:cpp:summary": "cd build/addon/tests && llvm-cov-19 report ./test-whisper-core --instr-profile=coverage.profdata -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' > coverage-summary.txt",
     "coverage:cpp:report": "cd build/addon/tests/ && ls -lha && llvm-profdata-19 merge -sparse default.profraw -o coverage.profdata && llvm-cov-19 show ./test-whisper-core -instr-profile=coverage.profdata -format=html -output-dir=coverage-html -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' && llvm-cov-19 export ./test-whisper-core -instr-profile=coverage.profdata -format=lcov -ignore-filename-regex='(tests|build|node_modules|gtest|gmock|\\.vcpkg|/usr)/' > lcov.info && npm run coverage:cpp:summary",
     "coverage:cpp": "npm run coverage:cpp:build && npm run test:cpp:run && npm run coverage:cpp:report",