fix[api]: use QvacErrorDecoderAudio with options object and replace generic Error throws (#1666)

Author: yuranich

packages/qvac-lib-decoder-audio/index.js

@@ -4,6 +4,7 @@ const QvacResponse = require('@qvac/response')
 const QvacLogger = require('@qvac/logging')
 const ffmpeg = require('bare-ffmpeg')
 const BaseInference = require('@qvac/infer-base/WeightsProvider/BaseInference')
+const { QvacErrorDecoderAudio, ERR_CODES } = require('./utils/error')
 
 /**
  * FFmpeg-based audio decoder (single-threaded)
@@ -106,7 +107,10 @@ class FFmpegDecoder extends BaseInference {
 
     // Validate audio format
     if (!this.SUPPORTED_AUDIO_FORMATS[this.config.audioFormat]) {
-      throw new Error(`Unsupported audio format: ${this.config.audioFormat}`)
+      throw new QvacErrorDecoderAudio({
+        code: ERR_CODES.UNSUPPORTED_AUDIO_FORMAT,
+        adds: this.config.audioFormat
+      })
     }
 
     this.isLoaded = true
@@ -135,7 +139,7 @@ class FFmpegDecoder extends BaseInference {
    */
   async run (audioStream) {
     if (!this.isLoaded) {
-      throw new Error('Decoder not loaded. Call load() first.')
+      throw new QvacErrorDecoderAudio({ code: ERR_CODES.DECODER_NOT_LOADED })
     }
 
     this.logger.info('Starting new audio stream processing')
@@ -397,7 +401,10 @@ class FFmpegDecoder extends BaseInference {
 
       const streamIndex = this.config.streamIndex || 0
       if (format.streams[streamIndex] === undefined) {
-        throw new Error('Stream index out of bounds')
+        throw new QvacErrorDecoderAudio({
+          code: ERR_CODES.STREAM_INDEX_OUT_OF_BOUNDS,
+          adds: streamIndex
+        })
       }
 
       // Process the stream and generate decoded output

packages/qvac-lib-decoder-audio/test/unit/StreamAccumulator.test.js

@@ -2,7 +2,7 @@
 
 const test = require('brittle')
 const createStreamAccumulator = require('../../utils/createStreamAccumulator.js')
-const { QvacErrorDecoderAudio } = require('../../utils/error.js')
+const { QvacErrorDecoderAudio, ERR_CODES } = require('../../utils/error.js')
 
 const TARGET_BUFFER_SIZE = 64000
 
@@ -88,6 +88,21 @@ test('validates buffer size configuration', (t) => {
     })
   }, QvacErrorDecoderAudio)
 
+  let captured
+  try {
+    createStreamAccumulator({
+      onChunk: () => {},
+      onFinish: () => {},
+      targetBufferSize: 1000
+    })
+  } catch (err) {
+    captured = err
+  }
+  t.ok(captured instanceof QvacErrorDecoderAudio)
+  t.is(captured.code, ERR_CODES.BUFFER_SIZE_TOO_SMALL)
+  t.is(captured.name, 'BUFFER_SIZE_TOO_SMALL')
+  t.is(captured.message, 'Target buffer size is too small')
+
   const accumulator = createStreamAccumulator({
     onChunk: () => {},
     onFinish: () => {},

packages/qvac-lib-decoder-audio/utils/createStreamAccumulator.js

@@ -22,7 +22,7 @@ function createStreamAccumulator ({
   targetBufferSize = TARGET_BUFFER_SIZE
 }) {
   if (targetBufferSize < TARGET_BUFFER_SIZE) {
-    throw new QvacErrorDecoderAudio(ERR_CODES.BUFFER_SIZE_TOO_SMALL)
+    throw new QvacErrorDecoderAudio({ code: ERR_CODES.BUFFER_SIZE_TOO_SMALL })
   }
 
   let accumulator = Buffer.alloc(0)

packages/qvac-lib-decoder-audio/utils/error.js

@@ -14,7 +14,10 @@ const ERR_CODES = Object.freeze({
   FAILED_TO_APPEND: 11005,
   FAILED_TO_GET_STATUS: 11006,
   FAILED_TO_DESTROY: 11007,
-  BUFFER_SIZE_TOO_SMALL: 11008
+  BUFFER_SIZE_TOO_SMALL: 11008,
+  UNSUPPORTED_AUDIO_FORMAT: 11009,
+  DECODER_NOT_LOADED: 11010,
+  STREAM_INDEX_OUT_OF_BOUNDS: 11011
 })
 
 addCodes({
@@ -49,6 +52,18 @@ addCodes({
   [ERR_CODES.BUFFER_SIZE_TOO_SMALL]: {
     name: 'BUFFER_SIZE_TOO_SMALL',
     message: 'Target buffer size is too small'
+  },
+  [ERR_CODES.UNSUPPORTED_AUDIO_FORMAT]: {
+    name: 'UNSUPPORTED_AUDIO_FORMAT',
+    message: (format) => `Unsupported audio format: ${format}`
+  },
+  [ERR_CODES.DECODER_NOT_LOADED]: {
+    name: 'DECODER_NOT_LOADED',
+    message: 'Decoder not loaded. Call load() first.'
+  },
+  [ERR_CODES.STREAM_INDEX_OUT_OF_BOUNDS]: {
+    name: 'STREAM_INDEX_OUT_OF_BOUNDS',
+    message: (index) => `Stream index out of bounds: ${index}`
   }
 }, {
   name,