Skip to content

Commit aee9549

Browse files
committed
Fix potential rerandomize loophole
1 parent 14f5bd5 commit aee9549

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/save.asm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ pre_load_state:
5353

5454
; Rerandomize
5555
LDA !sram_save_has_set_rng : BNE .done
56-
LDA !sram_rerandomize : AND #$00FF : BEQ .done
56+
LDA !sram_rerandomize : BEQ .done
5757
LDA !CACHED_RANDOM_NUMBER : STA !SRAM_SAVED_RNG
5858
LDA !FRAME_COUNTER : STA !SRAM_SAVED_FRAME_COUNTER
5959
LDA !ram_seed_X : STA !sram_seed_X
@@ -95,7 +95,7 @@ post_load_state:
9595
.rng
9696
; Rerandomize
9797
LDA !sram_save_has_set_rng : BNE .done
98-
LDA !sram_rerandomize : AND #$00FF : BEQ .done
98+
LDA !sram_rerandomize : BEQ .done
9999
LDA !SRAM_SAVED_RNG : STA !CACHED_RANDOM_NUMBER
100100
LDA !SRAM_SAVED_FRAME_COUNTER : STA !FRAME_COUNTER
101101
LDA !sram_seed_X : STA !ram_seed_X

src/tinystates.asm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ pre_load_state:
5353

5454
; Rerandomize
5555
LDA !sram_save_has_set_rng : BNE .done
56-
LDA !sram_rerandomize : AND #$00FF : BEQ .done
56+
LDA !sram_rerandomize : BEQ .done
5757
LDA !CACHED_RANDOM_NUMBER : STA !SRAM_SAVED_RNG
5858
LDA !FRAME_COUNTER : STA !SRAM_SAVED_FRAME_COUNTER
5959
LDA !ram_seed_X : STA !sram_seed_X
@@ -134,7 +134,7 @@ post_load_state:
134134
.rng
135135
; Rerandomize
136136
LDA !sram_save_has_set_rng : BNE .done
137-
LDA !sram_rerandomize : AND #$00FF : BEQ .done
137+
LDA !sram_rerandomize : BEQ .done
138138
LDA !SRAM_SAVED_RNG : STA !CACHED_RANDOM_NUMBER
139139
LDA !SRAM_SAVED_FRAME_COUNTER : STA !FRAME_COUNTER
140140
LDA !sram_seed_X : STA !ram_seed_X

0 commit comments

Comments
 (0)