Update drop edge tolerance to feel smoother

Author: texodus

src/core/constants.ts

@@ -110,8 +110,8 @@ export const DEFAULT_PHYSICS: Physics = Object.freeze({
 	SHOULD_ROUND: false,
 	OVERLAY_CLASSNAME: "overlay",
 	MINIMUM_REDISTRIBUTION_SIZE_THRESHOLD: 0.15,
-	SPLIT_EDGE_TOLERANCE: 0.25,
-	SPLIT_ROOT_EDGE_TOLERANCE: 0.01,
+	SPLIT_EDGE_TOLERANCE: 0.33,
+	SPLIT_ROOT_EDGE_TOLERANCE: 0.1,
 	GRID_TRACK_COLLAPSE_TOLERANCE: 0.001,
 	OVERLAY_DEFAULT: "absolute",
 	GRID_DIVIDER_SIZE: 6,

tests/unit/calculate_edge.spec.ts

@@ -13,14 +13,14 @@ import { expect, test } from "@playwright/test";
 import { LAYOUTS } from "../helpers/fixtures.ts";
 import { calculate_edge } from "../../src/layout/calculate_edge.ts";
 import { calculate_intersection } from "../../src/layout/calculate_intersect.ts";
-import type { Layout, LayoutPath } from "../../src/layout/types.ts";
+import type { Layout, LayoutPath } from "../../src/core/types.ts";
 
 test("cursor in center of panel - no split", () => {
-	const drop_target = calculate_intersection(0.3, 0.5, LAYOUTS.NESTED_BASIC);
+	const drop_target = calculate_intersection(0.3, 0.65, LAYOUTS.NESTED_BASIC);
 	expect(drop_target).not.toBeNull();
 	const result = calculate_edge(
 		0.3,
-		0.5,
+		0.65,
 		LAYOUTS.NESTED_BASIC,
 		"DDD",
 		// biome-ignore lint/style/noNonNullAssertion: playwright assertion
@@ -68,10 +68,10 @@ test("cursor near right edge of vertical split panel", () => {
 });
 
 test("cursor near top edge of horizontal split panel", () => {
-	const drop_target = calculate_intersection(0.7, 0.05, LAYOUTS.NESTED_BASIC);
+	const drop_target = calculate_intersection(0.75, 0.12, LAYOUTS.NESTED_BASIC);
 	const result = calculate_edge(
-		0.7,
-		0.05,
+		0.75,
+		0.12,
 		LAYOUTS.NESTED_BASIC,
 		"DDD",
 		// biome-ignore lint/style/noNonNullAssertion: playwright assertion
@@ -85,10 +85,10 @@ test("cursor near top edge of horizontal split panel", () => {
 });
 
 test("cursor near bottom edge of horizontal split panel", () => {
-	const drop_target = calculate_intersection(0.7, 0.95, LAYOUTS.NESTED_BASIC);
+	const drop_target = calculate_intersection(0.75, 0.88, LAYOUTS.NESTED_BASIC);
 	const result = calculate_edge(
-		0.7,
-		0.95,
+		0.75,
+		0.88,
 		LAYOUTS.NESTED_BASIC,
 		"DDD",
 		// biome-ignore lint/style/noNonNullAssertion: playwright assertion
@@ -313,24 +313,24 @@ test("cursor in bottom-right corner prioritizes row offset", () => {
 		layout: undefined as unknown as Layout,
 		path: [],
 		view_window: { row_start: 0, row_end: 1, col_start: 0, col_end: 1 },
-		column: 0.9,
-		row: 0.95,
-		column_offset: 0.9,
-		row_offset: 0.95,
+		column: 0.85,
+		row: 0.89,
+		column_offset: 0.85,
+		row_offset: 0.89,
 		orientation: "horizontal",
 		is_edge: false,
 	};
 
-	const result = calculate_edge(0.9, 0.95, singlePanel, "BBB", drop_target);
+	const result = calculate_edge(0.85, 0.89, singlePanel, "BBB", drop_target);
 	expect(result).toStrictEqual({
-		column: 0.9,
-		column_offset: 0.9,
+		column: 0.85,
+		column_offset: 0.85,
 		is_edge: true,
 		layout: undefined,
 		orientation: "vertical",
 		path: [1],
-		row: 0.95,
-		row_offset: 0.95,
+		row: 0.89,
+		row_offset: 0.89,
 		slot: "AAA",
 		type: "layout-path",
 		view_window: {
@@ -350,24 +350,24 @@ test("cursor in bottom-right corner prioritizes column offset", () => {
 		layout: undefined as unknown as Layout,
 		path: [],
 		view_window: { row_start: 0, row_end: 1, col_start: 0, col_end: 1 },
-		column: 0.95,
-		row: 0.9,
-		column_offset: 0.95,
-		row_offset: 0.9,
+		column: 0.89,
+		row: 0.85,
+		column_offset: 0.89,
+		row_offset: 0.85,
 		orientation: "horizontal",
 		is_edge: false,
 	};
 
-	const result = calculate_edge(0.95, 0.9, singlePanel, "BBB", drop_target);
+	const result = calculate_edge(0.89, 0.85, singlePanel, "BBB", drop_target);
 	expect(result).toStrictEqual({
-		column: 0.95,
-		column_offset: 0.95,
+		column: 0.89,
+		column_offset: 0.89,
 		is_edge: true,
 		layout: undefined,
 		orientation: "horizontal",
 		path: [1],
-		row: 0.9,
-		row_offset: 0.9,
+		row: 0.85,
+		row_offset: 0.85,
 		slot: "AAA",
 		type: "layout-path",
 		view_window: {
@@ -387,15 +387,15 @@ test("cursor near edge with offset exactly at tolerance threshold", () => {
 		path: [],
 		layout: undefined as unknown as Layout,
 		view_window: { row_start: 0, row_end: 1, col_start: 0, col_end: 1 },
-		column: 0.3,
+		column: 0.35,
 		row: 0.5,
-		column_offset: 0.3,
+		column_offset: 0.35,
 		row_offset: 0.5,
 		orientation: "horizontal",
 		is_edge: false,
 	};
 
-	const result = calculate_edge(0.3, 0.5, singlePanel, "BBB", drop_target);
+	const result = calculate_edge(0.35, 0.65, singlePanel, "BBB", drop_target);
 	expect(result.is_edge).toBe(false);
 	expect(result.path).toStrictEqual([0]);
 });
@@ -421,9 +421,9 @@ test("cursor near edge with offset just below tolerance threshold", () => {
 });
 
 test("nested panel with vertical orientation at left edge", () => {
-	const drop_target = calculate_intersection(0.02, 0.5, LAYOUTS.NESTED_BASIC);
+	const drop_target = calculate_intersection(0.12, 0.5, LAYOUTS.NESTED_BASIC);
 	const result = calculate_edge(
-		0.02,
+		0.12,
 		0.5,
 		LAYOUTS.NESTED_BASIC,
 		"DDD",