fix: drop remove container only option

- Remove the "Remove container only" button from bot detail page; operators only need full Remove/Delete
- Simplify `remove()` function to always delete config when removing a bot
- Delete `confirmRemoveContainerOnlyPlan()` function; consolidate all removal logic into `confirmRemovePlan()`
- Update documentation to reflect that Remove deletes both container and config in one step
- Reduce UI complexity by eliminating the keep-config escape hatch that could lead to config-only zombie bots

Author: bnolens

.textile-monorepo-source

@@ -1 +1 @@
-d97ac1d0e126045bb1eac762e208098e5144da97
+bf58a6cebce223a65e6633df6b70136c7d6bfd63

.textile-stitch-release-version

@@ -1 +1 @@
-0.1.211
+0.1.212

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "stitch-bot"
-version = "0.1.211"
+version = "0.1.212"
 edition = "2021"
 description = "Stitch — Textile filler-network operator bot; market-makes the filler order book with signed UniswapX limit orders."
 license = "AGPL-3.0-or-later"

Cargo.toml

@@ -493,9 +493,7 @@ create fails, or when someone removes the container and keeps the directory. Add
 Bot refuses that name; Recreate is the button. To drop it instead, use **Delete**
 on the fleet row (or on the bot page): that wipes the config and private key and
 takes the row off the fleet. **Remove** on a live bot deletes container + config
-in one step; Cancel aborts entirely. Keeping the files without a container is an
-explicit **Remove container only** action on the bot page, and it warns that the
-bot will stay on the fleet as config-only until you Delete or Recreate it.
+in one step; Cancel aborts entirely.
 
 What doesn't change: **saving settings on a running bot restarts it.** Stitch reads
 its config once at startup, so there's no way to apply a spread change in place.

docs/install-panel.md

@@ -19,10 +19,7 @@ import SettingsForm from '../components/SettingsForm'
 import StitchDashboardEmbed from '../components/StitchDashboardEmbed'
 import VersionRollback from '../components/VersionRollback'
 import { formatTimestamp, shortAddress, shortImage } from '../format'
-import {
-  confirmRemoveContainerOnlyPlan,
-  confirmRemovePlan,
-} from '../removeBot'
+import { confirmRemovePlan } from '../removeBot'
 import type { Bot, ConfigBody, MigrationResult, UpdatesStatus } from '../types'
 
 const TABS = ['settings', 'dashboard', 'config', 'logs', 'tools'] as const
@@ -124,13 +121,14 @@ export default function BotDetail() {
     }
   }
 
-  async function remove(full: boolean) {
-    const plan = full
-      ? confirmRemovePlan({ name, hasContainer: !!bot?.container })
-      : confirmRemoveContainerOnlyPlan(name)
+  async function remove() {
+    const plan = confirmRemovePlan({
+      name,
+      hasContainer: !!bot?.container,
+    })
     if (!plan) return
 
-    setBusy(full ? 'remove' : 'remove-container')
+    setBusy('remove')
     setError(null)
     try {
       const res = await api.remove(name, plan.deleteConfig)
@@ -294,31 +292,19 @@ export default function BotDetail() {
               </>
             )}
           </div>
-          <div className="flex w-full flex-col gap-2 sm:ml-auto sm:w-auto sm:flex-row sm:items-center">
-            {bot.container && (
-              <Button
-                busy={busy === 'remove-container'}
-                className="w-full sm:w-auto"
-                onClick={() => void remove(false)}
-                title="Destroy the container but leave config on disk — the bot stays on the fleet as config-only"
-              >
-                Remove container only
-              </Button>
-            )}
-            <Button
-              variant="danger"
-              busy={busy === 'remove'}
-              className="w-full sm:w-auto"
-              onClick={() => void remove(true)}
-              title={
-                bot.container
-                  ? 'Delete the container, config, and private key — gone from the fleet'
-                  : 'Delete config and private key — gone from the fleet'
-              }
-            >
-              {bot.container ? 'Remove' : 'Delete'}
-            </Button>
-          </div>
+          <Button
+            variant="danger"
+            busy={busy === 'remove'}
+            className="w-full sm:ml-auto sm:w-auto"
+            onClick={() => void remove()}
+            title={
+              bot.container
+                ? 'Delete the container, config, and private key — gone from the fleet'
+                : 'Delete config and private key — gone from the fleet'
+            }
+          >
+            {bot.container ? 'Remove' : 'Delete'}
+          </Button>
         </div>
 
         <dl className="mt-4 grid gap-3 text-sm sm:grid-cols-2 lg:grid-cols-4">

web/src/pages/BotDetail.tsx

@@ -8,11 +8,8 @@
 export type RemovePlan = { deleteConfig: boolean } | null
 
 /**
- * Ask what to remove.
- *
- * - No container: one confirm, always deletes config (the only thing left).
- * - Has container: one confirm for a full delete (container + config + key).
- *   Detail pages can also offer {@link confirmRemoveContainerOnlyPlan}.
+ * Ask what to remove. Always deletes config (and the container when there is
+ * one). Cancel aborts — nothing is removed.
  */
 export function confirmRemovePlan(opts: {
   name: string
@@ -39,21 +36,3 @@ export function confirmRemovePlan(opts: {
   }
   return { deleteConfig: true }
 }
-
-/**
- * Detail-only escape hatch: destroy the container, keep files on disk.
- *
- * The bot reappears on the fleet as config-only so Recreate can bring it back.
- * Explicit about that, because Cancel-means-keep on the main Remove path is how
- * operators ended up with zombies they couldn't see how to delete.
- */
-export function confirmRemoveContainerOnlyPlan(name: string): RemovePlan {
-  if (
-    !window.confirm(
-      `Remove ${name}'s container but keep its config and private key?\n\n${name} will stay on the fleet as config-only until you Delete it (or Recreate the container).`,
-    )
-  ) {
-    return null
-  }
-  return { deleteConfig: false }
-}