fix(desktop): drop supervisor lock before pause confirmation dialog

- Sample is_running state under a short lock, then release before calling confirm_panel_pause() to avoid deadlocking the UI thread on Linux
- gtk::Dialog::run() nests the GTK loop which can dispatch RefreshStatus events that also need the supervisor mutex; holding the lock across the dialog caused a 2-second status poll to freeze the pause confirmation
- Re-acquire the lock before stopping to handle the case where the supervisor state changed while the dialog was open
- Restructure the pause/resume logic to cleanly separate lock-acquisition phases

Author: bnolens

.textile-monorepo-source

@@ -1 +1 @@
-a953771c46c910ce1507c781200778ef395adb98
+8bb0b2114ccfeb59c263c8beb77ffa4b0d19912e

.textile-stitch-release-version

@@ -1 +1 @@
-0.1.164
+0.1.165

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "stitch-bot"
-version = "0.1.164"
+version = "0.1.165"
 edition = "2021"
 description = "Stitch — Textile filler-network operator bot; market-makes the filler order book with signed UniswapX limit orders."
 license = "AGPL-3.0-or-later"

Cargo.toml

@@ -669,15 +669,33 @@ fn run() -> Result<()> {
 }
 
 fn toggle_panel(supervisor: &Arc<Mutex<PanelSupervisor>>) {
-    if let Ok(mut s) = supervisor.lock() {
-        if s.is_running() {
-            if !confirm_panel_pause() {
+    // Sample running state under a short lock, then drop it before any
+    // blocking confirmation. On Linux, gtk::Dialog::run() nests the GTK loop
+    // and can dispatch RefreshStatus, which also needs this mutex — holding
+    // it across the dialog deadlocks the UI thread.
+    let running = match supervisor.lock() {
+        Ok(mut s) => s.is_running(),
+        Err(_) => return,
+    };
+
+    if running {
+        if !confirm_panel_pause() {
+            return;
+        }
+        if let Ok(mut s) = supervisor.lock() {
+            // State may have changed while the dialog was open.
+            if !s.is_running() {
                 return;
             }
             if let Err(e) = s.stop() {
                 eprintln!("pause failed: {e:#}");
             }
-        } else if let Err(e) = s.start() {
+        }
+        return;
+    }
+
+    if let Ok(mut s) = supervisor.lock() {
+        if let Err(e) = s.start() {
             eprintln!("resume failed: {e:#}");
         }
     }