fix(macos-app): include stitch binary in app bundle and show startup errors

- Fix workflow YAML syntax that caused stitch binary to be skipped from Stitch.app with a leading space in the path argument
- Change make-app.sh to require both stitch and stitch-panel binaries, failing the bundle build if either is missing instead of warning
- Add explicit Contents/MacOS file checks in workflow after app assembly
- Show native macOS dialog on stitch-desktop startup errors so Finder/Dock launches provide user feedback instead of silently failing
- Bump version to 0.1.143

Author: bnolens

.github/workflows/macos-app.yml

@@ -117,8 +117,20 @@ jobs:
       - name: Assemble Stitch.app
         # make-app.sh signs with $STITCH_CODESIGN_ID when set (Developer ID),
         # otherwise ad-hoc ("-").
-        run: packaging/macos/make-app.sh target/universal/stitch-desktop dist \
-          target/universal/stitch target/universal/stitch-panel
+        # Use a `|` block — a plain YAML scalar with `\` turns `\ ` into an
+        # escaped space, so arg3 became " target/universal/stitch" (leading
+        # space), stitch was omitted from the .app, and macOS launches exited
+        # immediately with nothing in the Dock / Activity Monitor.
+        run: |
+          set -euo pipefail
+          packaging/macos/make-app.sh \
+            target/universal/stitch-desktop \
+            dist \
+            target/universal/stitch \
+            target/universal/stitch-panel
+          test -f dist/Stitch.app/Contents/MacOS/stitch
+          test -f dist/Stitch.app/Contents/MacOS/stitch-panel
+          test -f dist/Stitch.app/Contents/MacOS/stitch-desktop
 
       - name: Build Stitch.dmg
         # Wrap the (signed) app in a drag-to-Applications image. make-dmg.sh signs

.textile-monorepo-source

@@ -1 +1 @@
-41ecfdddc55f234c926f892fff7f8c6dc6c1c10f
+2020079d7819291ecd5362322493932f130e3e03

.textile-stitch-release-version

@@ -1 +1 @@
-0.1.142
+0.1.143

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "stitch-bot"
-version = "0.1.142"
+version = "0.1.143"
 edition = "2021"
 description = "Stitch — Textile filler-network operator bot; market-makes the filler order book with signed UniswapX limit orders."
 license = "AGPL-3.0-or-later"

Cargo.toml

@@ -16,18 +16,21 @@ cp "$HERE/Info.plist" "$APP/Contents/Info.plist"
 cp "$BIN" "$APP/Contents/MacOS/stitch-desktop"
 chmod +x "$APP/Contents/MacOS/stitch-desktop"
 
-copy_helper() {
+# Both helpers are required. A missing `stitch` makes stitch-desktop exit
+# immediately on launch (Finder shows nothing — no Dock, no dialog).
+copy_required() {
   local src="$1"
   local name="$2"
-  if [ -f "$src" ]; then
-    cp "$src" "$APP/Contents/MacOS/$name"
-    chmod +x "$APP/Contents/MacOS/$name"
-  else
-    echo "warning: $name not found at $src; Start Panel will fail until it is present" >&2
+  if [ ! -f "$src" ]; then
+    echo "error: required binary '$name' not found at '$src'" >&2
+    echo "error: Stitch.app cannot launch without stitch + stitch-panel next to stitch-desktop" >&2
+    exit 1
   fi
+  cp "$src" "$APP/Contents/MacOS/$name"
+  chmod +x "$APP/Contents/MacOS/$name"
 }
-copy_helper "$STITCH_BIN" "stitch"
-copy_helper "$PANEL_BIN" "stitch-panel"
+copy_required "$STITCH_BIN" "stitch"
+copy_required "$PANEL_BIN" "stitch-panel"
 
 # App icon (referenced by CFBundleIconFile in Info.plist).
 if [ -f "$HERE/Stitch.icns" ]; then
@@ -47,12 +50,13 @@ if [ "$SIGN_ID" != "-" ]; then
 fi
 if command -v codesign >/dev/null 2>&1; then
   # shellcheck disable=SC2086
-  [ -f "$APP/Contents/MacOS/stitch" ] && codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP/Contents/MacOS/stitch"
+  codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP/Contents/MacOS/stitch"
   # shellcheck disable=SC2086
-  [ -f "$APP/Contents/MacOS/stitch-panel" ] && codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP/Contents/MacOS/stitch-panel"
+  codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP/Contents/MacOS/stitch-panel"
   # shellcheck disable=SC2086
   codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP/Contents/MacOS/stitch-desktop"
   # shellcheck disable=SC2086
   codesign --force $RUNTIME_OPT --sign "$SIGN_ID" "$APP"
 fi
 echo "Built $APP"
+ls -la "$APP/Contents/MacOS"

packaging/macos/make-app.sh

@@ -50,11 +50,43 @@ const STATUS_POLL_SECS: u64 = 2;
 
 fn main() {
     if let Err(e) = run() {
-        eprintln!("stitch-desktop: {e:#}");
+        let detail = format!("{e:#}");
+        eprintln!("stitch-desktop: {detail}");
+        // Finder launches have no terminal — surface fatal errors in a dialog
+        // so "double-click → nothing" isn't the only feedback.
+        show_launch_error(&detail);
         std::process::exit(1);
     }
 }
 
+/// Best-effort native alert when startup fails (macOS Finder / Dock launches).
+fn show_launch_error(detail: &str) {
+    #[cfg(target_os = "macos")]
+    {
+        // AppleScript string literals: escape `\`, `"`, and flatten newlines.
+        let escaped: String = detail
+            .replace('\\', "\\\\")
+            .replace('"', "\\\"")
+            .chars()
+            .map(|c| match c {
+                '\n' | '\r' => ' ',
+                other => other,
+            })
+            .collect();
+        let script = format!(
+            "display dialog \"Stitch couldn't start.\\n\\n{escaped}\" with title \"Stitch\" buttons {{\"OK\"}} default button \"OK\" with icon stop"
+        );
+        let _ = std::process::Command::new("/usr/bin/osascript")
+            .arg("-e")
+            .arg(script)
+            .status();
+    }
+    #[cfg(not(target_os = "macos"))]
+    {
+        let _ = detail;
+    }
+}
+
 fn launched_via_autostart() -> bool {
     std::env::args().any(|a| a == "--autostart")
 }