fix(macos): resolve finder -10010 error when laying out dmg

- Replace `container window of (POSIX file … as alias)` with explicit window target matching, as this throws AppleScript error -10010 on volume roots in modern macOS/CI environments
- Match finder windows by comparing their POSIX paths (with and without trailing slash) to handle edge cases like pre-existing /Volumes/Stitch mounts
- Remove `eject` call from finder automation and rely solely on closing matching windows, as eject on POSIX aliases triggers the same -10010 class error
- Add delay after opening mount to allow finder window to settle before querying
- Update dmg layout and detach logic to pass mount path with trailing slash variant for robust path comparison
- Bump version to 0.1.156

Author: bnolens

.textile-monorepo-source

@@ -1 +1 @@
-53ce11c2e79dccc8782edd597b4b5e5cb01ebfb5
+117a08291f972a928f36b7ada4c7f6daf9c66a29

.textile-stitch-release-version

@@ -1 +1 @@
-0.1.155
+0.1.156

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "stitch-bot"
-version = "0.1.155"
+version = "0.1.156"
 edition = "2021"
 description = "Stitch — Textile filler-network operator bot; market-makes the filler order book with signed UniswapX limit orders."
 license = "AGPL-3.0-or-later"

Cargo.toml

@@ -70,17 +70,38 @@ as_quote() {
   printf '%s' "$1" | sed 's/\\/\\\\/g; s/"/\\"/g'
 }
 MNT_AS="$(as_quote "$MNT")"
+# Trailing slash form — Finder's POSIX path of a folder target usually includes it.
+MNT_AS_SLASH="$(as_quote "${MNT%/}/")"
 # Let the volume settle before scripting Finder.
 sleep 2
 
 # Best-effort window layout: size, icon positions, and background. Finder
 # automation is available on the macOS CI runners; if it ever isn't, the image
 # still works — it just lacks the custom positions/arrow.
+#
+# Do NOT use `container window of (POSIX file … as alias)` — on modern macOS /
+# CI images that throws -10010 ("Handler can't handle objects of this class")
+# for volume roots. Open the mount, then pick the Finder window whose target
+# POSIX path matches this attach (so a pre-existing /Volumes/Stitch can't steal
+# the layout when we got /Volumes/Stitch 1).
 osascript <<OSA || echo "warning: Finder layout failed; shipping a plain drag-to-Applications image" >&2
-set mntAlias to POSIX file "$MNT_AS" as alias
+set mountPOSIX to "$MNT_AS"
+set mountPOSIXSlash to "$MNT_AS_SLASH"
 tell application "Finder"
+  set mntAlias to (POSIX file mountPOSIX) as alias
   open mntAlias
-  set win to container window of mntAlias
+  delay 1
+  set win to missing value
+  repeat with w in (every Finder window)
+    try
+      set targetPath to POSIX path of (target of w as alias)
+      if targetPath is mountPOSIX or targetPath is mountPOSIXSlash then
+        set win to w
+        exit repeat
+      end if
+    end try
+  end repeat
+  if win is missing value then error "no Finder window for " & mountPOSIX
   set current view of win to icon view
   set toolbar visible of win to false
   set statusbar visible of win to false
@@ -103,12 +124,12 @@ sync
 
 # Finder often keeps the volume busy for a few seconds after layout (Spotlight /
 # .DS_Store / the container window). A single detach or even -force can fail with
-# "Resource busy" (hdiutil exit 16) on CI runners. Close/eject *this* mount via
-# its POSIX path, then retry detach with backoff before converting.
+# "Resource busy" (hdiutil exit 16) on CI runners. Close windows for *this* mount
+# via its POSIX path, then retry detach with backoff before converting.
 is_detached() {
   local target="$1"
   local mount="$2"
-  # Mount point gone and device no longer listed → already ejected (e.g. via Finder).
+  # Mount point gone and device no longer listed → already ejected.
   if [ ! -d "$mount" ] && ! hdiutil info 2>/dev/null | grep -Fq "$target"; then
     return 0
   fi
@@ -119,17 +140,23 @@ detach_dmg() {
   local target="$1"
   local mount="$2"
   local mount_as="$3"
+  local mount_as_slash="$4"
   local attempt
   # Best-effort: drop Finder's hold on this mount before hdiutil fights it.
+  # Avoid `eject` on a POSIX alias (same -10010 class error as container window);
+  # closing matching windows is enough — hdiutil detach does the unmount.
   osascript <<OSA >/dev/null 2>&1 || true
-set mntAlias to POSIX file "$mount_as" as alias
+set mountPOSIX to "$mount_as"
+set mountPOSIXSlash to "$mount_as_slash"
 tell application "Finder"
-  try
-    close (every window whose target is mntAlias)
-  end try
-  try
-    eject mntAlias
-  end try
+  repeat with w in (every Finder window)
+    try
+      set targetPath to POSIX path of (target of w as alias)
+      if targetPath is mountPOSIX or targetPath is mountPOSIXSlash then
+        close w
+      end if
+    end try
+  end repeat
 end tell
 OSA
   if is_detached "$target" "$mount"; then
@@ -156,7 +183,7 @@ OSA
   return 1
 }
 
-detach_dmg "$DEV" "$MNT" "$MNT_AS"
+detach_dmg "$DEV" "$MNT" "$MNT_AS" "$MNT_AS_SLASH"
 hdiutil convert "$TMP_DMG" -format UDZO -imagekey zlib-level=9 -o "$DMG" >/dev/null
 
 # Ad-hoc ("-") DMGs aren't worth signing (nothing verifies them); sign only with