fix(desktop): cache autostart state and respect Windows light theme

- Cache autostart state at startup instead of querying OS on every refresh cycle, eliminating repeated registry calls on Windows that stall the UI thread
- Update cached autostart state only when toggle succeeds
- Replace hardcoded light glyphs on Windows with dynamic detection via AppsUseLightTheme registry key; use light glyphs on dark menus and dark glyphs on light menus
- Add parsing and tests for Windows registry theme detection; gracefully default to dark menus if registry query fails

Author: bnolens

.textile-monorepo-source

@@ -1 +1 @@
-ea6d78e6aa4826a87833c3792b3036d7bfc31748
+6819314f4b44a974b3920dd880f20448bc13ca97

.textile-stitch-release-version

@@ -1 +1 @@
-0.1.146
+0.1.147

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "stitch-bot"
-version = "0.1.146"
+version = "0.1.147"
 edition = "2021"
 description = "Stitch — Textile filler-network operator bot; market-makes the filler order book with signed UniswapX limit orders."
 license = "AGPL-3.0-or-later"

Cargo.toml

@@ -251,11 +251,15 @@ fn run() -> Result<()> {
     #[cfg(not(target_os = "macos"))]
     let hide_dock_row = false;
 
+    // Cache OS login-item state. RefreshStatus runs every few seconds; on Windows
+    // is_enabled() shells out to `reg query`, which stalls the UI thread.
+    let mut autostart_enabled = autostart::is_enabled();
+
     let html = if awaiting_signup {
         control_ui::signup_html(legacy_password_reset)
     } else {
         control_ui::html(
-            autostart::is_enabled(),
+            autostart_enabled,
             prefs.hide_dock_icon,
             panel_running,
             hide_dock_row,
@@ -313,7 +317,7 @@ fn run() -> Result<()> {
                         &supervisor,
                         !quiet_launch,
                         webview.as_ref(),
-                        autostart::is_enabled(),
+                        autostart_enabled,
                         prefs.hide_dock_icon,
                         update_version.as_deref(),
                     );
@@ -339,7 +343,7 @@ fn run() -> Result<()> {
                             &update_item,
                             &menu_icons,
                             webview.as_ref(),
-                            autostart::is_enabled(),
+                            autostart_enabled,
                             prefs.hide_dock_icon,
                             &supervisor,
                             update_version.as_deref(),
@@ -361,7 +365,7 @@ fn run() -> Result<()> {
                             Ok(()) => {
                                 awaiting_signup = false;
                                 let control_html = control_ui::html(
-                                    autostart::is_enabled(),
+                                    autostart_enabled,
                                     prefs.hide_dock_icon,
                                     false,
                                     hide_dock_row,
@@ -380,7 +384,7 @@ fn run() -> Result<()> {
                                         &supervisor,
                                         true,
                                         webview.as_ref(),
-                                        autostart::is_enabled(),
+                                        autostart_enabled,
                                         prefs.hide_dock_icon,
                                         update_version.as_deref(),
                                     );
@@ -403,6 +407,7 @@ fn run() -> Result<()> {
                         elwt,
                         control_flow,
                         webview.as_ref(),
+                        &mut autostart_enabled,
                         update_version.as_deref(),
                     );
                 }
@@ -420,7 +425,7 @@ fn run() -> Result<()> {
                 if !awaiting_signup {
                     sync_control_ui(
                         webview.as_ref(),
-                        autostart::is_enabled(),
+                        autostart_enabled,
                         prefs.hide_dock_icon,
                         &supervisor,
                         update_version.as_deref(),
@@ -439,7 +444,7 @@ fn run() -> Result<()> {
                 if !awaiting_signup {
                     sync_control_ui(
                         webview.as_ref(),
-                        autostart::is_enabled(),
+                        autostart_enabled,
                         prefs.hide_dock_icon,
                         &supervisor,
                         update_version.as_deref(),
@@ -593,6 +598,7 @@ fn handle_ipc(
     elwt: &tao::event_loop::EventLoopWindowTarget<UserEvent>,
     control_flow: &mut ControlFlow,
     webview: Option<&wry::WebView>,
+    autostart_enabled: &mut bool,
     update_version: Option<&str>,
 ) {
     match msg {
@@ -614,8 +620,9 @@ fn handle_ipc(
         }
         other if other.starts_with("toggle_autostart:") => {
             let enabled = other.ends_with(":1");
-            if let Err(e) = autostart::set_enabled(enabled) {
-                eprintln!("start at login failed: {e}");
+            match autostart::set_enabled(enabled) {
+                Ok(()) => *autostart_enabled = enabled,
+                Err(e) => eprintln!("start at login failed: {e}"),
             }
         }
         #[cfg(target_os = "macos")]
@@ -635,7 +642,7 @@ fn handle_ipc(
     }
     sync_control_ui(
         webview,
-        autostart::is_enabled(),
+        *autostart_enabled,
         prefs.hide_dock_icon,
         supervisor,
         update_version,

src/bin/stitch-desktop/main.rs

@@ -164,8 +164,7 @@ fn action_bitmap(icons: &MenuIcons, kind: ActionKind) -> Icon {
     }
 }
 
-/// Ink for monochrome glyphs. Prefer light glyphs on Windows (Win11 tray menus
-/// are usually dark) and when a dark GTK theme is advertised.
+/// Ink for monochrome glyphs. Light glyphs on dark menus; dark glyphs on light.
 #[cfg(not(target_os = "macos"))]
 fn menu_ink() -> (u8, u8, u8) {
     if prefer_light_glyphs() {
@@ -179,7 +178,9 @@ fn menu_ink() -> (u8, u8, u8) {
 fn prefer_light_glyphs() -> bool {
     #[cfg(target_os = "windows")]
     {
-        true
+        // AppsUseLightTheme=1 → light app chrome / menus → dark ink.
+        // Missing key or query failure: Win11 tray menus are usually dark.
+        !windows_apps_use_light_theme().unwrap_or(false)
     }
     #[cfg(not(target_os = "windows"))]
     {
@@ -189,6 +190,52 @@ fn prefer_light_glyphs() -> bool {
     }
 }
 
+/// `HKCU\...\Personalize\AppsUseLightTheme` — 1 light, 0 dark.
+#[cfg(target_os = "windows")]
+fn windows_apps_use_light_theme() -> Option<bool> {
+    use std::process::Command;
+    let output = Command::new("reg")
+        .args([
+            "query",
+            r"HKCU\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize",
+            "/v",
+            "AppsUseLightTheme",
+        ])
+        .output()
+        .ok()?;
+    if !output.status.success() {
+        return None;
+    }
+    parse_apps_use_light_theme_reg(&String::from_utf8_lossy(&output.stdout))
+}
+
+/// Parse `reg query … /v AppsUseLightTheme` stdout.
+#[cfg(any(test, target_os = "windows"))]
+fn parse_apps_use_light_theme_reg(stdout: &str) -> Option<bool> {
+    // Typical line: `    AppsUseLightTheme    REG_DWORD    0x1`
+    let value = stdout
+        .lines()
+        .find(|line| line.contains("AppsUseLightTheme"))?
+        .split_whitespace()
+        .last()?;
+    let n = u32::from_str_radix(value.trim_start_matches("0x"), 16).ok()?;
+    Some(n != 0)
+}
+
+#[cfg(test)]
+mod theme_ink_tests {
+    use super::parse_apps_use_light_theme_reg;
+
+    #[test]
+    fn parses_light_and_dark_reg_output() {
+        let light = "\nHKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize\n    AppsUseLightTheme    REG_DWORD    0x1\n\n";
+        let dark = "\nHKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize\n    AppsUseLightTheme    REG_DWORD    0x0\n\n";
+        assert_eq!(parse_apps_use_light_theme_reg(light), Some(true));
+        assert_eq!(parse_apps_use_light_theme_reg(dark), Some(false));
+        assert_eq!(parse_apps_use_light_theme_reg("nope"), None);
+    }
+}
+
 // --- Windows / Linux bitmap fallbacks (32×32, anti-aliased) ---
 
 #[cfg(not(target_os = "macos"))]