Skip to content

Commit a0e40fb

Browse files
committed
fix: PR opendatahub-io#995 comments opendatahub-io#5 and opendatahub-io#2 — move datasource, fix LokiStack URL
- Move loki-datasource.yaml to observability/dashboards/ next to its dashboard (follows Prometheus datasource co-location convention) - Change hardcoded LokiStack URL from lokistack-sample/logging4 to logging-loki/openshift-logging (standard namespace) - Update loki/ and dashboards/ kustomization references accordingly
1 parent 722a520 commit a0e40fb

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

deployment/components/observability/loki/kustomization.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ metadata:
88

99
resources:
1010
- loki-ca.yaml
11-
- loki-datasource.yaml
1211
- loki-rbac.yaml
1312
- loki-secret.yaml
1413
- loki-datasource-scoped.yaml

deployment/components/observability/observability/dashboards/kustomization.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ resources:
1010
- prometheus-web-tls-ca-configmap.yaml
1111
- kuadrant-prometheus-datasource.yaml
1212
- usage-dashboard.yaml
13+
- loki-datasource.yaml
1314
- usage-admin-loki-dashboard.yaml
1415
- usage-user-loki-dashboard.yaml
15-
# Loki datasource infrastructure (CA, RBAC, secret, datasource CRs)
16+
# Loki infrastructure (CA, RBAC, secret, scoped datasource)
1617
- ../../loki
1718

1819
labels:

deployment/components/observability/loki/loki-datasource.yaml renamed to deployment/components/observability/observability/dashboards/loki-datasource.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ spec:
1919
proxy:
2020
kind: HTTPProxy
2121
spec:
22-
url: https://lokistack-sample-gateway-http.logging4.svc.cluster.local:8080/api/logs/v1/application
22+
# LokiStack gateway URL — adjust name/namespace to match your LokiStack CR.
23+
url: https://logging-loki-gateway-http.openshift-logging.svc.cluster.local:8080/api/logs/v1/application
2324
allowedEndpoints:
2425
- endpointPattern: "/loki/api/v1/.*"
2526
method: GET

0 commit comments

Comments
 (0)