Fix concurrency warnings (#7)

Author: tgrapperon

Sources/CompressionDependency/Compressor.swift

@@ -46,15 +46,15 @@ public struct Compressor: Sendable {
   /// Compresses the provided data synchronously, using the provided algorithm.
   public func callAsFunction(
     _ data: Data,
-    using algorithm: Algorithm = .zlib
+    using algorithm:  @Sendable @autoclosure () -> Algorithm = .zlib
   ) throws -> Data {
-    try self.compress(data, algorithm)
+    try self.compress(data, algorithm())
   }
   /// Compresses the provided data asynchronously, using the provided algorithm.
   public func callAsFunction(
     _ data: Data,
-    using algorithm: Algorithm = .zlib
+    using algorithm: @Sendable @autoclosure () -> Algorithm = .zlib
   ) async throws -> Data {
-    try await self.compressAsync(data, algorithm)
+    try await self.compressAsync(data, algorithm())
   }
 }

Sources/CompressionDependency/Decompressor.swift

@@ -49,16 +49,16 @@ public struct Decompressor: Sendable {
   /// Decompresses the provided data synchronously, using the provided algorithm.
   public func callAsFunction(
     _ data: Data,
-    using algorithm: Algorithm = .zlib
+    using algorithm: @Sendable @autoclosure () -> Algorithm = .zlib
   ) throws -> Data {
-    try self.decompress(data, algorithm)
+    try self.decompress(data, algorithm())
   }
 
   /// Decompresses the provided data asynchronously, using the provided algorithm.
   public func callAsFunction(
     _ data: Data,
-    using algorithm: Algorithm = .zlib
+    using algorithm: @Sendable @autoclosure () -> Algorithm = .zlib
   ) async throws -> Data {
-    try await self.decompressAsync(data, algorithm)
+    try await self.decompressAsync(data, algorithm())
   }
 }

Sources/DependenciesAdditionsBasics/Proxies.swift

@@ -121,7 +121,7 @@ public struct ReadWriteBinding<Value>: Sendable {
     self.set = getSet.1
   }
   /// Initializes a ``ReadWriteProxy`` from a ``ProxyBindable`` value, like `LockIsolated`.
-  public init<Bindable: ProxyBindable>(_ bindable: Bindable) where Bindable.Value == Value {
+  public init<Bindable: ProxyBindable & Sendable>(_ bindable: Bindable) where Bindable.Value == Value {
     self.init(
       get: {
         bindable.getValue()
@@ -133,7 +133,7 @@ public struct ReadWriteBinding<Value>: Sendable {
   }
 
   /// Initializes a ``ReadWriteProxy`` from a ``ProxyBindable`` value, like `LockIsolated`.
-  public static func bind<Bindable: ProxyBindable>(bindable: Bindable) -> Self
+  public static func bind<Bindable: ProxyBindable & Sendable>(bindable: Bindable) -> Self
   where Bindable.Value == Value {
     .init(bindable)
   }
@@ -299,7 +299,7 @@ public struct MainActorReadWriteBinding<Value>: Sendable {
     self.set = getSet.1
   }
 
-  public init<Bindable: ProxyBindable>(_ bindable: Bindable) where Bindable.Value == Value {
+  public init<Bindable: ProxyBindable & Sendable>(_ bindable: Bindable) where Bindable.Value == Value {
     self.init(
       get: {
         bindable.getValue()
@@ -422,23 +422,24 @@ public struct MainActorReadOnlyProxy<Value: Sendable>: Sendable {
 ///
 /// `LockIsolated` is conforming to this protocol, so you can use `LockIsolated` values
 /// to control writable dependencies properties during tests and SwiftUI previews.
-@dynamicMemberLookup
+//@dynamicMemberLookup
 public protocol ProxyBindable {
   associatedtype Value: Sendable
   var getValue: @Sendable () -> Value { get }
   var setValue: @Sendable (Value) -> Void { get }
 }
 
-extension ProxyBindable {
-  public subscript(dynamicMember keyPath: ReferenceWritableKeyPath<Self, Value>)
-    -> AnyProxyBindable<Value>
-  {
-    return AnyProxyBindable<Value>(
-      getValue: { self[keyPath: keyPath] },
-      setValue: { self[keyPath: keyPath] = $0 }
-    )
-  }
-}
+// Removed for now until a proper way to handle the non-sendable capture is found
+//extension ProxyBindable {
+//  public subscript(dynamicMember keyPath: ReferenceWritableKeyPath<Self, Value>)
+//    -> AnyProxyBindable<Value>
+//  {
+//    return AnyProxyBindable<Value>(
+//      getValue: { self[keyPath: keyPath] },
+//      setValue: { self[keyPath: keyPath] = $0 }
+//    )
+//  }
+//}
 
 /// An erased ``ProxyBindable`` property.
 ///
@@ -447,12 +448,13 @@ extension ProxyBindable {
 ///
 /// For example, `LockIsolated(["a", "b", "c"]).count` returns an ``AnyProxyBindable<Int>``
 /// that you can bind to a writable dependency.
-public struct AnyProxyBindable<Value>: ProxyBindable {
+public struct AnyProxyBindable<Value: Sendable>: ProxyBindable {
   public var getValue: @Sendable () -> Value
   public var setValue: @Sendable (Value) -> Void
 }
 
-extension LockIsolated: ProxyBindable {
+public protocol _Sendable: Sendable {}
+extension LockIsolated: ProxyBindable where Value: _Sendable {
   public var getValue: @Sendable () -> Value {
     { self.value }
   }

Sources/NotificationCenterDependency/NotificationCenterDependency.swift

@@ -58,16 +58,16 @@ extension NotificationCenter {
       >
 
     init(
-      post: @escaping @Sendable (
+      @_inheritActorContext post: @escaping @Sendable (
         NSNotification.Name, AnyObject?, [AnyHashable: Any]?, StaticString, UInt
       ) -> Void,
-      addObserver: @escaping @Sendable (
+      @_inheritActorContext addObserver: @escaping @Sendable (
         AnyObject, Selector, NSNotification.Name?, AnyObject?, StaticString, UInt
       ) -> Void,
-      removeObserver: @escaping @Sendable (
+      @_inheritActorContext removeObserver: @escaping @Sendable (
         AnyObject, NSNotification.Name?, AnyObject?, StaticString, UInt
       ) -> Void,
-      publisher: @escaping @Sendable (Notification.Name, AnyObject?, StaticString, UInt) ->
+      @_inheritActorContext publisher: @escaping @Sendable (Notification.Name, AnyObject?, StaticString, UInt) ->
         AnyPublisher<Notification, Never>
     ) {
       self._post = post

Tests/NotificationCenterDependencyTests/NotificationCenterDependencyTests.swift

@@ -2,10 +2,11 @@ import Dependencies
 @_spi(Internals) import DependenciesAdditionsBasics
 import NotificationCenterDependency
 import XCTest
-
 @MainActor
 final class NotificationCenterDependencyTests: XCTestCase {
+  nonisolated
   func notificationName1() -> Notification.Name { .init("NotificationCenterDependencyTests_1") }
+  nonisolated
   func notificationName2() -> Notification.Name { .init("NotificationCenterDependencyTests_2") }
 
   // TODO: Strenghten this
@@ -20,7 +21,10 @@ final class NotificationCenterDependencyTests: XCTestCase {
       await withTimeout { group in
         group.addTask {
           var count = 0
-          for await notification in notificationCenter.notifications(named: n1) {
+          let notifications = await MainActor.run{
+            UncheckedSendable(notificationCenter.notifications(named: n1))
+          }.value
+          for await notification in notifications {
             XCTAssertEqual(notification.name, n1)
             count += 1
             if count == 3 { break }