phase9-wave5-t55-c1a-seq116: add objective lifecycle governance events

th3vib3coder · th3vib3coder · commit bc4e61338916 · 2026-04-29T22:02:09.000+02:00
Land VRE-side objective lifecycle governance event adoption for CLI-owned objective transitions. objective start/stop/pause/resume now emit objective_started/objective_completed/objective_paused/objective_resumed through the seq 113 plugin bridge after durable state commits, with sanitized details and fail-soft telemetry.

Tests: objective-cli 17/17; objective-lock 9/9; VRE test:phase9 398 pass / 0 fail / 5 skipped; VRE validate 13/13; plugin test:phase9 48/48; plugin npm test 173 e2e + 342 phase8 + 48 phase9; wiki-lint issueCount 0.
diff --git a/environment/objectives/cli.js b/environment/objectives/cli.js
@@ -37,6 +37,24 @@ import {
   writeResumeSnapshot
 } from './resume-snapshot.js';
 import { assertReviewer2Gate } from '../orchestrator/agent-orchestration.js';
+import { logGovernanceEventViaPlugin } from '../orchestrator/governance-logger.js';
+
+const OBJECTIVE_CLI_GOVERNANCE_SOURCE_COMPONENT = 'vre/objectives/cli';
+
+async function recordObjectiveLifecycleGovernanceEvent(eventType, objectiveId, details) {
+  try {
+    await logGovernanceEventViaPlugin({
+      event_type: eventType,
+      source_component: OBJECTIVE_CLI_GOVERNANCE_SOURCE_COMPONENT,
+      objective_id: objectiveId,
+      severity: 'info',
+      details
+    });
+  } catch (error) {
+    const code = typeof error?.code === 'string' ? error.code : 'E_GOVERNANCE_BRIDGE_FAILED';
+    process.stderr.write(`[phase9-governance] ${eventType} telemetry failed: ${code}\n`);
+  }
+}
 
 function toRepoRelative(projectRoot, targetPath) {
   return normalizeSlashes(path.relative(projectRoot, targetPath));
@@ -289,6 +307,14 @@ export async function startObjectiveCommand(repoRoot, { objectiveRecord, session
       await rm(path.dirname(objectiveRecordPath(repoRoot, activation.objectiveRecord.objectiveId)), { recursive: true, force: true }).catch(() => {});
       throw error;
     }
+    await recordObjectiveLifecycleGovernanceEvent(
+      'objective_started',
+      activation.objectiveRecord.objectiveId,
+      {
+        runtimeMode: activation.objectiveRecord.runtimeMode,
+        reasoningMode: activation.objectiveRecord.reasoningMode
+      }
+    );
 
     return phase9SuccessPayload('objective start', {
       objectiveId: activation.objectiveRecord.objectiveId,
@@ -318,6 +344,9 @@ export async function pauseObjectiveCommand(repoRoot, { objectiveId, reason }, d
       }
     );
     const persistedHandshake = await persistHandshake(repoRoot, deps);
+    await recordObjectiveLifecycleGovernanceEvent('objective_paused', objectiveId, {
+      pauseReason: 'operator-pause'
+    });
     return phase9SuccessPayload('objective pause', {
       objectiveId,
       reason,
@@ -354,6 +383,9 @@ export async function stopObjectiveCommand(repoRoot, { objectiveId, reason }, de
       }
     );
     const persistedHandshake = await persistHandshake(repoRoot, deps);
+    await recordObjectiveLifecycleGovernanceEvent('objective_completed', objectiveId, {
+      terminalStatus: result.objectiveRecord.status
+    });
     return phase9SuccessPayload('objective stop', {
       objectiveId,
       reason,
@@ -470,6 +502,10 @@ export async function resumeObjectiveCommand(repoRoot, { objectiveId, repairSnap
         blockerResolved
       });
       const persistedHandshake = await persistHandshake(repoRoot, deps);
+      await recordObjectiveLifecycleGovernanceEvent('objective_resumed', objectiveId, {
+        repairSnapshot: Boolean(repairSnapshot),
+        blockerResolved
+      });
 
       return phase9SuccessPayload('objective resume', {
         objectiveId,
diff --git a/environment/tests/cli/objective-cli.test.js b/environment/tests/cli/objective-cli.test.js
@@ -23,6 +23,13 @@ const FIXTURE_KERNEL_ENV = {
     'tests',
     'fixtures',
     'fake-kernel-sibling'
+  ),
+  VIBE_SCIENCE_PLUGIN_CLI: path.join(
+    repoRoot,
+    'environment',
+    'tests',
+    'fixtures',
+    'governance-log-capture-stub.js'
   )
 };
 
@@ -71,6 +78,33 @@ async function readJson(targetPath) {
   return JSON.parse(await readFile(targetPath, 'utf8'));
 }
 
+async function readGovernanceEvents(capturePath) {
+  try {
+    const raw = await readFile(capturePath, 'utf8');
+    return raw
+      .trim()
+      .split(/\r?\n/u)
+      .filter(Boolean)
+      .map((line) => JSON.parse(line));
+  } catch (error) {
+    if (error?.code === 'ENOENT') {
+      return [];
+    }
+    throw error;
+  }
+}
+
+function assertNoDetailsLeak(event, forbiddenValues) {
+  const serialized = JSON.stringify(event.details ?? {});
+  for (const value of forbiddenValues) {
+    assert.equal(
+      serialized.includes(value),
+      false,
+      `governance details leaked forbidden value ${value}: ${serialized}`
+    );
+  }
+}
+
 async function readFixtureJson(section, fileName) {
   return JSON.parse(
     await readFile(
@@ -123,6 +157,212 @@ async function writeBlockerFlag(projectRoot, objectiveId) {
   });
 }
 
+test('objective start emits an objective_started governance event after state commit', async () => {
+  const projectRoot = await createCliFixtureProject('vre-objective-cli-governance-start-');
+  const capturePath = path.join(projectRoot, '.governance-events.jsonl');
+  try {
+    const result = await runVre(projectRoot, buildObjectiveStartArgs(), {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_SESSION_ID: 'sess-governance-start',
+        VRE_GOVERNANCE_CAPTURE_PATH: capturePath
+      }
+    });
+    assert.equal(result.code, 0, `stderr=${result.stderr}`);
+
+    const objectiveRecord = await readJson(
+      path.join(projectRoot, '.vibe-science-environment', 'objectives', 'OBJ-001', 'objective.json')
+    );
+    assert.equal(objectiveRecord.status, 'active');
+
+    const events = await readGovernanceEvents(capturePath);
+    assert.equal(events.length, 1);
+    assert.equal(events[0].event_type, 'objective_started');
+    assert.equal(events[0].source_component, 'vre/objectives/cli');
+    assert.equal(events[0].objective_id, 'OBJ-001');
+    assert.deepEqual(events[0].details, {
+      runtimeMode: 'unattended-batch',
+      reasoningMode: 'rule-only'
+    });
+    assertNoDetailsLeak(events[0], ['demo objective', 'why-now', projectRoot]);
+  } finally {
+    await cleanupCliFixtureProject(projectRoot);
+  }
+});
+
+test('objective stop emits an objective_completed governance event with terminal status only', async () => {
+  const projectRoot = await createCliFixtureProject('vre-objective-cli-governance-stop-');
+  const capturePath = path.join(projectRoot, '.governance-events.jsonl');
+  const secretReason = 'operator closure SECRET-seq116-stop';
+  try {
+    await runVre(projectRoot, buildObjectiveStartArgs(), {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_SESSION_ID: 'sess-governance-stop'
+      }
+    });
+
+    const result = await runVre(projectRoot, [
+      'objective',
+      'stop',
+      '--objective',
+      'OBJ-001',
+      '--reason',
+      secretReason
+    ], {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_GOVERNANCE_CAPTURE_PATH: capturePath
+      }
+    });
+    assert.equal(result.code, 0, `stderr=${result.stderr}`);
+
+    const objectiveRecord = await readJson(
+      path.join(projectRoot, '.vibe-science-environment', 'objectives', 'OBJ-001', 'objective.json')
+    );
+    assert.equal(objectiveRecord.status, 'abandoned');
+
+    const events = await readGovernanceEvents(capturePath);
+    assert.equal(events.length, 1);
+    assert.equal(events[0].event_type, 'objective_completed');
+    assert.equal(events[0].source_component, 'vre/objectives/cli');
+    assert.equal(events[0].objective_id, 'OBJ-001');
+    assert.deepEqual(events[0].details, {
+      terminalStatus: 'abandoned'
+    });
+    assertNoDetailsLeak(events[0], [secretReason, projectRoot, 'active-objective.json']);
+  } finally {
+    await cleanupCliFixtureProject(projectRoot);
+  }
+});
+
+test('objective pause emits an objective_paused governance event without raw operator reason', async () => {
+  const projectRoot = await createCliFixtureProject('vre-objective-cli-governance-pause-');
+  const capturePath = path.join(projectRoot, '.governance-events.jsonl');
+  const rawReason = 'operator pause SECRET-seq116-pause C:/sensitive/path';
+  try {
+    await runVre(projectRoot, buildObjectiveStartArgs(), {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_SESSION_ID: 'sess-governance-pause'
+      }
+    });
+
+    const result = await runVre(projectRoot, [
+      'objective',
+      'pause',
+      '--objective',
+      'OBJ-001',
+      '--reason',
+      rawReason
+    ], {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_GOVERNANCE_CAPTURE_PATH: capturePath
+      }
+    });
+    assert.equal(result.code, 0, `stderr=${result.stderr}`);
+
+    const objectiveRecord = await readJson(
+      path.join(projectRoot, '.vibe-science-environment', 'objectives', 'OBJ-001', 'objective.json')
+    );
+    assert.equal(objectiveRecord.status, 'paused');
+
+    const events = await readGovernanceEvents(capturePath);
+    assert.equal(events.length, 1);
+    assert.equal(events[0].event_type, 'objective_paused');
+    assert.equal(events[0].source_component, 'vre/objectives/cli');
+    assert.equal(events[0].objective_id, 'OBJ-001');
+    assert.deepEqual(events[0].details, {
+      pauseReason: 'operator-pause'
+    });
+    assertNoDetailsLeak(events[0], [rawReason, 'SECRET-seq116-pause', 'C:/sensitive/path']);
+  } finally {
+    await cleanupCliFixtureProject(projectRoot);
+  }
+});
+
+test('objective resume emits an objective_resumed governance event with boolean details', async () => {
+  const projectRoot = await createCliFixtureProject('vre-objective-cli-governance-resume-');
+  const capturePath = path.join(projectRoot, '.governance-events.jsonl');
+  try {
+    await runVre(projectRoot, buildObjectiveStartArgs(), {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_SESSION_ID: 'sess-governance-resume'
+      }
+    });
+    await runVre(projectRoot, [
+      'objective',
+      'pause',
+      '--objective',
+      'OBJ-001',
+      '--reason',
+      'operator pause before resume'
+    ], {
+      env: FIXTURE_KERNEL_ENV
+    });
+
+    const result = await runVre(projectRoot, [
+      'objective',
+      'resume',
+      '--objective',
+      'OBJ-001'
+    ], {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_GOVERNANCE_CAPTURE_PATH: capturePath
+      }
+    });
+    assert.equal(result.code, 0, `stderr=${result.stderr}`);
+
+    const objectiveRecord = await readJson(
+      path.join(projectRoot, '.vibe-science-environment', 'objectives', 'OBJ-001', 'objective.json')
+    );
+    assert.equal(objectiveRecord.status, 'active');
+
+    const events = await readGovernanceEvents(capturePath);
+    assert.equal(events.length, 1);
+    assert.equal(events[0].event_type, 'objective_resumed');
+    assert.equal(events[0].source_component, 'vre/objectives/cli');
+    assert.equal(events[0].objective_id, 'OBJ-001');
+    assert.deepEqual(events[0].details, {
+      repairSnapshot: false,
+      blockerResolved: false
+    });
+    assertNoDetailsLeak(events[0], [projectRoot, 'resume-snapshot.json', 'operator pause before resume']);
+  } finally {
+    await cleanupCliFixtureProject(projectRoot);
+  }
+});
+
+test('objective lifecycle governance bridge failure does not roll back the objective command', async () => {
+  const projectRoot = await createCliFixtureProject('vre-objective-cli-governance-fail-soft-');
+  const missingCli = path.join(projectRoot, 'missing-governance-log.js');
+  try {
+    const result = await runVre(projectRoot, buildObjectiveStartArgs(), {
+      env: {
+        ...FIXTURE_KERNEL_ENV,
+        VRE_SESSION_ID: 'sess-governance-fail-soft',
+        VIBE_SCIENCE_PLUGIN_CLI: missingCli
+      }
+    });
+    assert.equal(result.code, 0, `stderr=${result.stderr}`);
+    assert.doesNotMatch(result.stderr, new RegExp(missingCli.replace(/[.*+?^${}()|[\]\\]/gu, '\\$&'), 'u'));
+
+    const payload = JSON.parse(result.stdout);
+    assert.equal(payload.ok, true);
+    assert.equal(payload.objectiveId, 'OBJ-001');
+
+    const objectiveRecord = await readJson(
+      path.join(projectRoot, '.vibe-science-environment', 'objectives', 'OBJ-001', 'objective.json')
+    );
+    assert.equal(objectiveRecord.status, 'active');
+  } finally {
+    await cleanupCliFixtureProject(projectRoot);
+  }
+});
+
 test('objective start rejects unattended-batch without a wake policy and emits structured JSON', async () => {
   const projectRoot = await createCliFixtureProject('vre-objective-cli-no-wake-');
   try {
diff --git a/environment/tests/control/objective-lock.test.js b/environment/tests/control/objective-lock.test.js
@@ -17,6 +17,13 @@ const FIXTURE_KERNEL_ENV = {
     'tests',
     'fixtures',
     'fake-kernel-sibling'
+  ),
+  VIBE_SCIENCE_PLUGIN_CLI: path.join(
+    repoRoot,
+    'environment',
+    'tests',
+    'fixtures',
+    'governance-log-capture-stub.js'
   )
 };
 
diff --git a/environment/tests/fixtures/governance-log-capture-stub.js b/environment/tests/fixtures/governance-log-capture-stub.js
@@ -0,0 +1,20 @@
+import { appendFile } from 'node:fs/promises';
+
+let stdin = '';
+process.stdin.setEncoding('utf8');
+
+for await (const chunk of process.stdin) {
+  stdin += chunk;
+}
+
+const payload = JSON.parse(stdin || '{}');
+const capturePath = process.env.VRE_GOVERNANCE_CAPTURE_PATH;
+if (capturePath) {
+  await appendFile(capturePath, `${JSON.stringify(payload)}\n`, 'utf8');
+}
+
+process.stdout.write(JSON.stringify({
+  ok: true,
+  eventId: 'GOV-STUB-001',
+  code: 'OK'
+}));
diff --git a/phase9-vre-feature-ledger.md b/phase9-vre-feature-ledger.md
