Skip to content

Commit a0e4deb

Browse files
authored
Merge pull request moby#51440 from thaJeztah/plugins_no_pointer
api, client: don't use a pointer-slice for plugins
2 parents 22112fa + 15a048c commit a0e4deb

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

api/types/plugin/plugin_responses.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
)
66

77
// ListResponse contains the response for the Engine API
8-
type ListResponse []*Plugin
8+
type ListResponse []Plugin
99

1010
// Privilege describes a permission the user has to accept
1111
// upon installing a plugin.

client/plugin_list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type PluginListOptions struct {
1515

1616
// PluginListResult represents the result of a plugin list operation.
1717
type PluginListResult struct {
18-
Items []*plugin.Plugin
18+
Items []plugin.Plugin
1919
}
2020

2121
// PluginList returns the installed plugins

client/plugin_list_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func TestPluginList(t *testing.T) {
6464
return nil, fmt.Errorf("%s not set in URL query properly. Expected '%s', got %s", key, expected, actual)
6565
}
6666
}
67-
return mockJSONResponse(http.StatusOK, nil, []*plugin.Plugin{
67+
return mockJSONResponse(http.StatusOK, nil, []plugin.Plugin{
6868
{ID: "plugin_id1"},
6969
{ID: "plugin_id2"},
7070
})(req)

vendor/github.com/moby/moby/api/types/plugin/plugin_responses.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/moby/moby/client/plugin_list.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)