Skip to content

Commit d94c62f

Browse files
authored
Merge pull request moby#52015 from slyt3/51980-bind-propagation-image
daemon/volume: Drop BindOptions for image mounts
2 parents b7b19a7 + d809806 commit d94c62f

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

daemon/volume/mounts/linux_parser.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -356,13 +356,9 @@ func (p *linuxParser) parseMountSpec(cfg mount.Mount, validateBindSourceExists b
356356
// NOP
357357
case mount.TypeImage:
358358
mp.Source = cfg.Source
359-
if cfg.BindOptions != nil && len(cfg.BindOptions.Propagation) > 0 {
360-
mp.Propagation = cfg.BindOptions.Propagation
361-
} else {
362-
// If user did not specify a propagation mode, get
363-
// default propagation mode.
364-
mp.Propagation = linuxDefaultPropagationMode
365-
}
359+
// Propagation is currently not configurable for image mounts.
360+
// See https://github.com/moby/moby/issues/51980#issuecomment-3848407167
361+
mp.Propagation = linuxDefaultPropagationMode
366362
default:
367363
// TODO(thaJeztah): make switch exhaustive: anything to do for mount.TypeNamedPipe, mount.TypeCluster ?
368364
}

0 commit comments

Comments
 (0)