Skip to content

Commit 42b3c91

Browse files
committed
ci: include lint in same matrix
Make sure we lint on all Go versions to prevent fixing linting issues that don't apply to old versions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent a985354 commit 42b3c91

1 file changed

Lines changed: 10 additions & 21 deletions

File tree

.github/workflows/test.yml

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
jobs:
2121

2222
linux:
23-
name: Test ${{ matrix.platform }} (${{ matrix.go || 'oldest' }})
23+
name: ${{ matrix.platform }} (${{ matrix.go || 'oldest' }})
2424
timeout-minutes: 10
2525
strategy:
2626
fail-fast: false
@@ -41,13 +41,17 @@ jobs:
4141
with:
4242
go-version: ${{ matrix.go }}
4343
go-version-file: "go.mod" # used when go-version is not specified.
44+
- name: Lint
45+
uses: golangci/golangci-lint-action@v9
46+
with:
47+
args: --timeout=5m
4448
- name: Build for ${{ matrix.platform }}
4549
run: go build ./...
4650
- name: Test
4751
run: go test -exec sudo -v ./...
4852

4953
other:
50-
name: Test ${{ matrix.platform }} (${{ matrix.go || 'oldest' }})
54+
name: ${{ matrix.platform }} (${{ matrix.go || 'oldest' }})
5155
timeout-minutes: 10
5256
strategy:
5357
fail-fast: false
@@ -66,26 +70,11 @@ jobs:
6670
with:
6771
go-version: ${{ matrix.go }}
6872
go-version-file: "go.mod" # used when go-version is not specified.
73+
- name: Lint
74+
uses: golangci/golangci-lint-action@v9
75+
with:
76+
args: --timeout=5m
6977
- name: Build for ${{ matrix.platform }}
7078
run: go build ./...
7179
- name: Test
7280
run: go test -v ./...
73-
74-
lint:
75-
name: Lint ${{ matrix.platform }}
76-
timeout-minutes: 10
77-
strategy:
78-
fail-fast: false
79-
matrix:
80-
platform: [ubuntu-24.04, windows-latest, macos-latest]
81-
runs-on: ${{ matrix.platform }}
82-
steps:
83-
- uses: actions/checkout@v6
84-
- uses: actions/setup-go@v6
85-
with:
86-
go-version: "stable"
87-
cache: false
88-
- name: golangci-lint
89-
uses: golangci/golangci-lint-action@v9
90-
with:
91-
args: --timeout=5m

0 commit comments

Comments
 (0)