Merge pull request #328 from thand-io/fix/deterministic-notifier-order

fix(workflows): deterministic notifier task ordering

Author: hughneale

internal/workflows/tasks/providers/thand/approvals.go

@@ -3,6 +3,8 @@ package thand
 import (
 	"errors"
 	"fmt"
+	"maps"
+	"slices"
 	"time"
 
 	cloudevents "github.com/cloudevents/sdk-go/v2"
@@ -434,7 +436,8 @@ func (t *thandTask) makeApprovalNotifications(
 	// In parallel create a notifier for each of the notifiers
 	// Build notification tasks for each provider
 	var notifyTasks []notifyTask
-	for providerKey, notifierRequest := range approvalsTask.Notifiers {
+	for _, providerKey := range slices.Sorted(maps.Keys(approvalsTask.Notifiers)) {
+		notifierRequest := approvalsTask.Notifiers[providerKey]
 		// Create an ApprovalNotifier for each provider
 		approvalNotifier := NewApprovalsNotifier(
 			t.config,
@@ -546,7 +549,8 @@ func (t *thandTask) notifyApprovalRejection(
 	}
 
 	// Send rejection notification using each configured notifier
-	for providerKey, notifierRequest := range approvalsTask.Notifiers {
+	for _, providerKey := range slices.Sorted(maps.Keys(approvalsTask.Notifiers)) {
+		notifierRequest := approvalsTask.Notifiers[providerKey]
 		// Create a generic notifier for rejection with the approver as recipient
 		rejectionRequest := thandFunction.NotifierRequest{
 			Provider: notifierRequest.Provider,

internal/workflows/tasks/providers/thand/authorize.go

@@ -3,7 +3,9 @@ package thand
 import (
 	"errors"
 	"fmt"
+	"maps"
 	"net/http"
+	"slices"
 	"sync"
 	"time"
 
@@ -562,7 +564,8 @@ func (t *thandTask) makeAuthorizationNotifications(
 
 	// Build notification tasks for each provider
 	var notifyTasks []notifyTask
-	for providerKey, notifierRequest := range authorizeTask.Notifiers {
+	for _, providerKey := range slices.Sorted(maps.Keys(authorizeTask.Notifiers)) {
+		notifierRequest := authorizeTask.Notifiers[providerKey]
 		// Create an AuthorizerNotifier for each provider
 		authorizeNotifier := NewAuthorizerNotifier(
 			t.config,

internal/workflows/tasks/providers/thand/form.go

@@ -4,6 +4,8 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"maps"
+	"slices"
 
 	cloudevents "github.com/cloudevents/sdk-go/v2"
 	"github.com/serverlessworkflow/sdk-go/v3/model"
@@ -248,7 +250,8 @@ func (t *thandTask) makeFormNotifications(
 
 	var notifyTasks []notifyTask
 
-	for providerKey, notifierRequest := range formTask.Notifiers {
+	for _, providerKey := range slices.Sorted(maps.Keys(formTask.Notifiers)) {
+		notifierRequest := formTask.Notifiers[providerKey]
 		// Create a FormNotifier for each provider
 		formNotifier := NewFormNotifier(
 			t.config,

internal/workflows/tasks/providers/thand/revoke.go

@@ -3,6 +3,8 @@ package thand
 import (
 	"errors"
 	"fmt"
+	"maps"
+	"slices"
 	"sync"
 	"time"
 
@@ -366,7 +368,8 @@ func (t *thandTask) makeRevocationNotifications(
 
 	// Build notification tasks for each provider
 	var notifyTasks []notifyTask
-	for providerKey, notifierRequest := range revokeTask.Notifiers {
+	for _, providerKey := range slices.Sorted(maps.Keys(revokeTask.Notifiers)) {
+		notifierRequest := revokeTask.Notifiers[providerKey]
 		// Create a RevokeNotifier for each provider
 		revokeNotifier := NewRevokeNotifier(
 			t.config,