Merge pull request #153 from thand-io/provider-activities-enable

Enable activities for remaining providers

Author: hughneale

internal/models/provider_activities.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 
 	"github.com/sirupsen/logrus"
+	"go.temporal.io/sdk/temporal"
 )
 
 // RegisterActivities registers provider-specific activities with the Temporal worker
@@ -22,6 +23,26 @@ func NewProviderActivities(provider ProviderImpl) *ProviderActivities {
 	}
 }
 
+func (a *ProviderActivities) AuthorizeRole(
+	ctx context.Context,
+	req *AuthorizeRoleRequest,
+) (*AuthorizeRoleResponse, error) {
+
+	logrus.Infoln("Starting AuthorizeRole activity")
+	return handleNotImplementedError(a.provider.AuthorizeRole(ctx, req))
+
+}
+
+func (a *ProviderActivities) RevokeRole(
+	ctx context.Context,
+	req *RevokeRoleRequest,
+) (*RevokeRoleResponse, error) {
+
+	logrus.Infoln("Starting RevokeRole activity")
+	return handleNotImplementedError(a.provider.RevokeRole(ctx, req))
+
+}
+
 func (a *ProviderActivities) SynchronizeIdentities(
 	ctx context.Context,
 	req SynchronizeUsersRequest,
@@ -97,10 +118,11 @@ func (a *ProviderActivities) SynchronizeRoles(
 func handleNotImplementedError[T any](res T, err error) (T, error) {
 	if err != nil {
 		if errors.Is(err, ErrNotImplemented) {
-			// Ignore not implemented errors. This will
-			// just complete the activity as successful without doing anything.
-			logrus.WithError(err).Infoln("Activity not implemented for this provider, skipping")
-			return res, nil
+			return res, temporal.NewNonRetryableApplicationError(
+				"activity not implemented for this provider",
+				"NotImplementedError",
+				err,
+			)
 		}
 	}
 	return res, err

internal/providers/aws/activities.go

@@ -10,7 +10,7 @@ func (b *awsProvider) RegisterActivities(temporalClient models.TemporalImpl) err
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
 
-// Aws uses static roles and permissions so we don't need to them.
+// Aws uses static roles and permissions so we don't need to fetch them.
 // Instead we will just return these in the synchronize call.
 func (p *awsProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
 

internal/providers/azure/activities.go

@@ -10,7 +10,7 @@ func (b *azureProvider) RegisterActivities(temporalClient models.TemporalImpl) e
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
 
-// Azure uses static roles and permissions so we don't need to them.
+// Azure uses static roles and permissions so we don't need to fetch them.
 // Instead we will just return these in the synchronize call.
 func (p *azureProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
 

internal/providers/cloudflare/activities.go

@@ -1,7 +1,17 @@
 package cloudflare
 
-import "github.com/thand-io/agent/internal/models"
+import (
+	"context"
+
+	"github.com/thand-io/agent/internal/models"
+)
 
 func (b *cloudflareProvider) RegisterActivities(temporalClient models.TemporalImpl) error {
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
+
+// Cloudflare uses static roles and permissions so we don't need to fetch them.
+// Instead we will just return these in the synchronize call.
+func (p *cloudflareProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
+	return models.Synchronize(ctx, temporalService, p)
+}

internal/providers/gcp/activities.go

@@ -10,7 +10,7 @@ func (b *gcpProvider) RegisterActivities(temporalClient models.TemporalImpl) err
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
 
-// GCP uses static roles and permissions so we don't need to them.
+// GCP uses static roles and permissions so we don't need to fetch them.
 // Instead we will just return these in the synchronize call.
 func (p *gcpProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
 

internal/providers/github/activities.go

@@ -10,7 +10,7 @@ func (b *githubProvider) RegisterActivities(temporalClient models.TemporalImpl)
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
 
-// GitHub uses static roles and permissions so we don't need to them.
+// GitHub uses static roles and permissions so we don't need to fetch them.
 // Instead we will just return these in the synchronize call.
 func (p *githubProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
 

internal/providers/gsuite/activities.go

@@ -1,7 +1,17 @@
 package gsuite
 
-import "github.com/thand-io/agent/internal/models"
+import (
+	"context"
+
+	"github.com/thand-io/agent/internal/models"
+)
 
 func (b *gsuiteProvider) RegisterActivities(temporalClient models.TemporalImpl) error {
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
+
+// GSuite uses static roles and permissions so we don't need to fetch them.
+// Instead we will just return these in the synchronize call.
+func (p *gsuiteProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
+	return models.Synchronize(ctx, temporalService, p)
+}

internal/providers/kubernetes/activities.go

@@ -1,9 +1,17 @@
 package kubernetes
 
 import (
+	"context"
+
 	"github.com/thand-io/agent/internal/models"
 )
 
 func (b *kubernetesProvider) RegisterActivities(temporalClient models.TemporalImpl) error {
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
+
+// Kubernetes uses static roles and permissions so we don't need to fetch them.
+// Instead we will just return these in the synchronize call.
+func (p *kubernetesProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
+	return models.Synchronize(ctx, temporalService, p)
+}

internal/providers/okta/activities.go

@@ -10,7 +10,7 @@ func (b *oktaProvider) RegisterActivities(temporalClient models.TemporalImpl) er
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
 
-// GitHub uses static roles and permissions so we don't need to them.
+// GitHub uses static roles and permissions so we don't need to fetch them.
 // Instead we will just return these in the synchronize call.
 func (p *oktaProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
 

internal/providers/salesforce/activities.go

@@ -1,7 +1,17 @@
 package salesforce
 
-import "github.com/thand-io/agent/internal/models"
+import (
+	"context"
+
+	"github.com/thand-io/agent/internal/models"
+)
 
 func (b *salesForceProvider) RegisterActivities(temporalClient models.TemporalImpl) error {
 	return models.RegisterActivities(temporalClient, models.NewProviderActivities(b))
 }
+
+// Salesforce uses static roles and permissions so we don't need to fetch them.
+// Instead we will just return these in the synchronize call.
+func (p *salesForceProvider) Synchronize(ctx context.Context, temporalService models.TemporalImpl) error {
+	return models.Synchronize(ctx, temporalService, p)
+}