Query: fix partial response for distributed instant query

MichaHoffmann · MichaHoffmann · commit 7efeb7865cf3 · 2025-04-17T07:00:32.000Z
This commit fixes a typo in partial response handling for distributed
instant queries.

Signed-off-by: Michael Hoffmann &lt;mhoffmann@cloudflare.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,8 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 
 ### Fixed
 
+- [#8211](https://github.com/thanos-io/thanos/pull/8211) Query: fix panic on nested partial response in distributed instant query
+
 ## [v0.38.0](https://github.com/thanos-io/thanos/tree/release-0.38) - 03.04.2025
 
 ### Fixed
diff --git a/pkg/api/query/grpc.go b/pkg/api/query/grpc.go
@@ -120,7 +120,7 @@ func (g *GRPCAPI) Query(request *querypb.QueryRequest, server querypb.Query_Quer
 	})
 	if result.Err != nil {
 		if request.EnablePartialResponse {
-			if err := server.Send(querypb.NewQueryWarningsResponse(err)); err != nil {
+			if err := server.Send(querypb.NewQueryWarningsResponse(result.Err)); err != nil {
 				return err
 			}
 			return nil

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ func (g GRPCAPI) Query(request querypb.QueryRequest, server querypb.Query_Quer`
`120`	`120`	`})`
`121`	`121`	`if result.Err != nil {`
`122`	`122`	`if request.EnablePartialResponse {`
`123`		`- if err := server.Send(querypb.NewQueryWarningsResponse(err)); err != nil {`
	`123`	`+ if err := server.Send(querypb.NewQueryWarningsResponse(result.Err)); err != nil {`
`124`	`124`	`return err`
`125`	`125`	`}`
`126`	`126`	`return nil`