Skip to content

Commit ed689ed

Browse files
committed
ruler: correctly pass query partial response
Ruler doesn't set PartialResponse for gRPC clients, so it's always false. It only sets it for HTTP clients. > Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
1 parent cdca548 commit ed689ed

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

cmd/thanos/rule.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1011,7 +1011,9 @@ func queryFuncCreator(
10111011
if grpcEndpointSet != nil {
10121012
queryAPIClients := grpcEndpointSet.GetQueryAPIClients()
10131013
for _, i := range rand.Perm(len(queryAPIClients)) {
1014-
e := query.NewRemoteEngine(logger, queryAPIClients[i], query.Opts{})
1014+
e := query.NewRemoteEngine(logger, queryAPIClients[i], query.Opts{
1015+
PartialResponse: partialResponseStrategy == storepb.PartialResponseStrategy_WARN,
1016+
})
10151017
expr, err := extpromql.ParseExpr(qs)
10161018
if err != nil {
10171019
level.Error(logger).Log("err", err, "query", qs)

0 commit comments

Comments
 (0)