Skip to content

Positive indication in logs whether GOMEMLIMIT was set. #8483

@Jaypers

Description

@Jaypers

Is your proposal related to a problem?

Although there is a negative indication when --enable-auto-gomemlimit fails to set the GOMEMLIMIT
i.e. "Failed to set GOMEMLIMIT automatically"
there is no way to see if GOMEMLIMIT was set and set correctly.

Describe the solution you'd like

For Thanos to print something in the logs (or debug logs) to indicate that the limit was set and what exactly it was set to.

e.g.:
GOMEMLIMIT set to 2147483648 bytes, 90% of pod memory limit.
or
GOMEMLIMIT set to 2147483648 bytes, 90% of detected memory.

Describe alternatives you've considered

Go debugger

Additional context

It seems that our compactors are not honouring --enable-auto-gomemlimit running on ARM images.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions