Skip to content

Commit 9bfde4c

Browse files
committed
Address code rabbit comments
1 parent 8ee8fb6 commit 9bfde4c

File tree

1 file changed

+4
-3
lines changed
  • components/apimgt/org.wso2.carbon.apimgt.rest.api.admin.v1/src/main/java/org/wso2/carbon/apimgt/rest/api/admin/v1/utils/mappings

1 file changed

+4
-3
lines changed

components/apimgt/org.wso2.carbon.apimgt.rest.api.admin.v1/src/main/java/org/wso2/carbon/apimgt/rest/api/admin/v1/utils/mappings/SettingsMappingUtil.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,13 +169,14 @@ private static List<SettingsGatewayConfigurationDTO> getSettingsGatewayConfigura
169169
settingsFederatedGatewayConfigurationDTO.setDisplayName(gatewayConfiguration.getType());
170170
settingsFederatedGatewayConfigurationDTO.setDefaultHostnameTemplate(gatewayConfiguration.getDefaultHostnameTemplate());
171171
List<String> supportedModes = gatewayConfiguration.getSupportedModes();
172-
if (supportedModes.isEmpty()) {
172+
List<String> effectiveModes = (supportedModes == null) ? new ArrayList<>() : new ArrayList<>(supportedModes);
173+
if (effectiveModes.isEmpty()) {
173174
log.warn(String.format(
174175
"No supported modes derived for gateway type '%s'. Defaulting to '%s'",
175176
gatewayConfiguration.getType(), GatewayMode.WRITE_ONLY.getMode()));
176-
supportedModes.add(GatewayMode.WRITE_ONLY.getMode());
177+
effectiveModes.add(GatewayMode.WRITE_ONLY.getMode());
177178
}
178-
settingsFederatedGatewayConfigurationDTO.setSupportedModes(supportedModes);
179+
settingsFederatedGatewayConfigurationDTO.setSupportedModes(effectiveModes);
179180
List<ConfigurationDto> connectionConfigurations = gatewayConfiguration.getConnectionConfigurations();
180181
if (connectionConfigurations != null) {
181182
for (ConfigurationDto dto : connectionConfigurations) {

0 commit comments

Comments
 (0)