Fix review suggestions from coderabbit

tharikaGitHub · tharikaGitHub · commit d72af327a6cd · 2025-08-14T22:58:54.000+05:30
diff --git a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/APIConsumerImpl.java b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/APIConsumerImpl.java
@@ -3808,7 +3808,7 @@ private static Map<String, String> extractEndpointUrlsForDiscoveredApi(API api)
             }
             JsonObject configObject = configElement.getAsJsonObject();
             JsonArray servers = configObject.getAsJsonArray("servers");
-            if (servers == null || servers.isEmpty()) {
+            if (servers == null || servers.size() == 0) {
                 return null;
             }
             JsonObject server = servers.get(0).getAsJsonObject();
diff --git a/components/apimgt/org.wso2.carbon.apimgt.rest.api.store.v1/src/main/java/org/wso2/carbon/apimgt/rest/api/store/v1/mappings/APIMappingUtil.java b/components/apimgt/org.wso2.carbon.apimgt.rest.api.store.v1/src/main/java/org/wso2/carbon/apimgt/rest/api/store/v1/mappings/APIMappingUtil.java
@@ -563,7 +563,7 @@ private static APIURLsDTO extractEndpointUrlsForDiscoveredApi(APIDTO apidto) {
             }
             JsonObject configObject = configElement.getAsJsonObject();
             JsonArray servers = configObject.getAsJsonArray("servers");
-            if (servers == null || servers.isEmpty()) {
+            if (servers == null || servers.size() == 0) {
                 return null;
             }
             JsonObject server = servers.get(0).getAsJsonObject();

Original file line number	Diff line number	Diff line change
`@@ -3808,7 +3808,7 @@ private static Map<String, String> extractEndpointUrlsForDiscoveredApi(API api)`
`3808`	`3808`	`}`
`3809`	`3809`	`JsonObject configObject = configElement.getAsJsonObject();`
`3810`	`3810`	`JsonArray servers = configObject.getAsJsonArray("servers");`
`3811`		`- if (servers == null \|\| servers.isEmpty()) {`
	`3811`	`+ if (servers == null \|\| servers.size() == 0) {`
`3812`	`3812`	`return null;`
`3813`	`3813`	`}`
`3814`	`3814`	`JsonObject server = servers.get(0).getAsJsonObject();`
Original file line number	Diff line number	Diff line change
`@@ -563,7 +563,7 @@ private static APIURLsDTO extractEndpointUrlsForDiscoveredApi(APIDTO apidto) {`
`563`	`563`	`}`
`564`	`564`	`JsonObject configObject = configElement.getAsJsonObject();`
`565`	`565`	`JsonArray servers = configObject.getAsJsonArray("servers");`
`566`		`- if (servers == null \|\| servers.isEmpty()) {`
	`566`	`+ if (servers == null \|\| servers.size() == 0) {`
`567`	`567`	`return null;`
`568`	`568`	`}`
`569`	`569`	`JsonObject server = servers.get(0).getAsJsonObject();`