test(ingest): add FakeIntentProvider and align NewHandler test calls to new signature

- Create FakeIntentProvider test stub implementing IntentProvider interface
- Update all 12 NewHandler calls in handler_test.go to include third IntentProvider argument
- Fixes typecheck errors: 'not enough arguments in call to NewHandler'
- Signature change: NewHandler(validator, outDir) -> NewHandler(validator, outDir, provider)
- All tests now compile and pass basic execution

Author: thc1006

internal/ingest/fake_provider_test.go

@@ -0,0 +1,73 @@
+package ingest
+
+import (
+	"context"
+)
+
+// FakeIntentProvider is a test implementation of the IntentProvider interface
+// that returns deterministic responses for testing purposes.
+type FakeIntentProvider struct {
+	// ParseResult allows customizing the return value of ParseIntent
+	ParseResult map[string]interface{}
+	// ParseError allows customizing the error returned by ParseIntent
+	ParseError error
+	// ProviderName allows customizing the name returned by Name()
+	ProviderName string
+}
+
+// NewFakeIntentProvider creates a new FakeIntentProvider with default values
+func NewFakeIntentProvider() *FakeIntentProvider {
+	return &FakeIntentProvider{
+		ParseResult: map[string]interface{}{
+			"intent_type": "scaling",
+			"target":      "test-deployment",
+			"namespace":   "default",
+			"replicas":    3,
+			"source":      "test",
+		},
+		ParseError:   nil,
+		ProviderName: "fake",
+	}
+}
+
+// ParseIntent implements the IntentProvider interface
+// Returns the configured ParseResult and ParseError
+func (f *FakeIntentProvider) ParseIntent(ctx context.Context, text string) (map[string]interface{}, error) {
+	if f.ParseError != nil {
+		return nil, f.ParseError
+	}
+	
+	// Return a copy to avoid accidental modification
+	result := make(map[string]interface{})
+	for k, v := range f.ParseResult {
+		result[k] = v
+	}
+	
+	return result, nil
+}
+
+// Name implements the IntentProvider interface
+func (f *FakeIntentProvider) Name() string {
+	if f.ProviderName == "" {
+		return "fake"
+	}
+	return f.ProviderName
+}
+
+// WithParseResult allows chaining to set custom parse result
+func (f *FakeIntentProvider) WithParseResult(result map[string]interface{}) *FakeIntentProvider {
+	f.ParseResult = result
+	return f
+}
+
+// WithParseError allows chaining to set custom parse error
+func (f *FakeIntentProvider) WithParseError(err error) *FakeIntentProvider {
+	f.ParseError = err
+	return f
+}
+
+// WithName allows chaining to set custom provider name
+func (f *FakeIntentProvider) WithName(name string) *FakeIntentProvider {
+	f.ProviderName = name
+	return f
+}

internal/ingest/handler_test.go

@@ -36,7 +36,7 @@ func TestNewHandler(t *testing.T) {
 	outDir := filepath.Join(tempDir, "handoff")
 
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, outDir)
+	handler := NewHandler(mockValidator, outDir, NewFakeIntentProvider())
 
 	if handler == nil {
 		t.Fatal("Expected non-nil handler")
@@ -59,7 +59,7 @@ func TestNewHandler(t *testing.T) {
 func TestHandleIntent_MethodNotAllowed(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	methods := []string{"GET", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS"}
 
@@ -80,7 +80,7 @@ func TestHandleIntent_MethodNotAllowed(t *testing.T) {
 func TestHandleIntent_JSONInput_Success(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name        string
@@ -210,7 +210,7 @@ func TestHandleIntent_JSONInput_Success(t *testing.T) {
 func TestHandleIntent_PlainTextInput_Success(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name     string
@@ -306,7 +306,7 @@ func TestHandleIntent_PlainTextInput_Success(t *testing.T) {
 func TestHandleIntent_PlainTextInput_BadFormat(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name  string
@@ -366,7 +366,7 @@ func TestHandleIntent_PlainTextInput_BadFormat(t *testing.T) {
 func TestHandleIntent_UnsupportedContentType(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name        string
@@ -402,7 +402,7 @@ func TestHandleIntent_UnsupportedContentType(t *testing.T) {
 func TestHandleIntent_ValidationError(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name          string
@@ -472,7 +472,7 @@ func TestHandleIntent_FileWriteError(t *testing.T) {
 	os.MkdirAll(readOnlyDir, 0o444) // Create read-only directory
 
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, readOnlyDir)
+	handler := NewHandler(mockValidator, readOnlyDir, NewFakeIntentProvider())
 
 	// Mock successful validation
 	mockValidator.ValidateBytesFunc = func(b []byte) (*Intent, error) {
@@ -505,7 +505,7 @@ func TestHandleIntent_FileWriteError(t *testing.T) {
 func TestHandleIntent_FileCreation(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	payload := `{"intent_type": "scaling", "target": "test-deployment", "namespace": "default", "replicas": 3}`
 
@@ -563,7 +563,7 @@ func TestHandleIntent_FileCreation(t *testing.T) {
 func TestHandleIntent_ConcurrentRequests(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	const numRequests = 5 // Reduced to minimize timestamp collisions
 	results := make(chan int, numRequests)
@@ -620,7 +620,7 @@ func TestHandleIntent_ConcurrentRequests(t *testing.T) {
 func TestHandleIntent_CorrelationIdPassthrough(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	correlationID := "test-correlation-123"
 	payload := fmt.Sprintf(`{
@@ -667,7 +667,7 @@ func TestHandleIntent_CorrelationIdPassthrough(t *testing.T) {
 func TestHandleIntent_EdgeCases(t *testing.T) {
 	tempDir := t.TempDir()
 	mockValidator := &MockValidator{}
-	handler := NewHandler(mockValidator, tempDir)
+	handler := NewHandler(mockValidator, tempDir, NewFakeIntentProvider())
 
 	tests := []struct {
 		name         string