fix(ci): ULTRA SPEED comprehensive fixes - iteration 7

🚀 MULTIPLE SPECIALIZED AGENTS COORDINATION:
- deployment-engineer: Fixed Ginkgo CLI workflow with 2025 best practices
- debugger: Fixed all remaining Go compilation and vet errors
- search-specialist: Researched latest Ginkgo v2 CI patterns

🔧 GINKGO CLI WORKFLOW FIXES:
- Added Ginkgo CLI installation with go install github.com/onsi/ginkgo/v2/ginkgo@latest
- Replaced go test with ginkgo CLI using --procs=2 --randomize-all --randomize-suites
- Added intelligent fallback to go test for non-Ginkgo specs
- Implemented progress monitoring and enhanced error reporting

💻 GO COMPILATION FIXES:
- Updated OranAdaptorReconciler to use interface types instead of concrete types
- Fixed all fake test adaptors with missing interface methods (Connect, Disconnect, ClearAlarm)
- Resolved MockA1Service signature mismatches and added missing methods
- Fixed type declaration conflicts and duplicate struct definitions
- Cleaned up unused imports, variables, and format issues

📊 RESULTS: 19 failures → targeting 0 failures
Next: Comprehensive 15+ minute CI testing with maximum timeout

🤖 Generated with [Claude Code](https://claude.ai/code) - ULTRA SPEED MODE

Co-Authored-By: Claude <noreply@anthropic.com>

Author: thc1006

.github/workflows/ci-reliability-optimized.yml

@@ -2,7 +2,7 @@
 # CI Reliability Optimized Pipeline - DevOps Best Practices 2025
 # =============================================================================
 # Purpose: Ultra-reliable CI with optimized caching, Go 1.25.x compatibility,
-#          and enterprise-grade timeout management
+#          Ginkgo v2 test framework support, and enterprise-grade timeout management
 # =============================================================================
 
 name: CI Reliability Optimized
@@ -336,6 +336,12 @@ jobs:
             nephoran-reliability-v3-${{ runner.os }}-go1.25
           fail-on-cache-miss: false
 
+      - name: Install Ginkgo CLI
+        run: |
+          echo "Installing Ginkgo CLI for 2025 best practices..."
+          go install github.com/onsi/ginkgo/v2/ginkgo@latest
+          ginkgo version
+          
       - name: Setup test environment
         if: contains(matrix.test-suite.pattern, './controllers/') || contains(matrix.test-suite.pattern, './api/')
         run: |
@@ -351,31 +357,56 @@ jobs:
           KUBEBUILDER_ASSETS: ${{ env.KUBEBUILDER_ASSETS }}
           CGO_ENABLED: 1  # Required for -race flag
         run: |
-          echo "Running ${{ matrix.test-suite.name }} tests..."
+          echo "Running ${{ matrix.test-suite.name }} tests with Ginkgo CLI..."
           
           # Create results directory
           mkdir -p test-results
           
-          # Configure test flags
-          TEST_FLAGS="-v -timeout=5m -parallel=4"
+          # Configure Ginkgo flags for 2025 best practices
+          GINKGO_FLAGS="--procs=2 --randomize-all --randomize-suites --timeout=5m --poll-progress-after=30s --poll-progress-interval=10s"
           
           # Add coverage if requested
           if [ "${{ matrix.test-suite.coverage }}" = "true" ]; then
-            TEST_FLAGS="$TEST_FLAGS -coverprofile=test-results/coverage-${{ matrix.test-suite.name }}.out -covermode=atomic"
+            GINKGO_FLAGS="$GINKGO_FLAGS --coverprofile=test-results/coverage-${{ matrix.test-suite.name }}.out --covermode=atomic"
           fi
           
           # Add race detection for critical tests
           if [ "${{ matrix.test-suite.name }}" = "unit-critical" ]; then
-            TEST_FLAGS="$TEST_FLAGS -race"
+            GINKGO_FLAGS="$GINKGO_FLAGS --race"
           fi
           
+          # Convert go test patterns to directories for Ginkgo
+          TEST_DIRS=$(echo "${{ matrix.test-suite.pattern }}" | sed 's|/\.\.\.|/|g' | sed 's|\./||g')
+          
           # Run tests with retry on failure (network issues)
           for attempt in 1 2; do
-            echo "Test attempt $attempt/2"
-            if go test $TEST_FLAGS ${{ matrix.test-suite.pattern }}; then
-              echo "✅ Tests passed successfully"
-              break
-            elif [ $attempt -eq 2 ]; then
+            echo "Ginkgo test attempt $attempt/2"
+            echo "Running: ginkgo $GINKGO_FLAGS $TEST_DIRS"
+            
+            # Check if directories exist and have tests
+            has_tests=false
+            for dir in $TEST_DIRS; do
+              if find "$dir" -name "*_test.go" -o -name "*_suite_test.go" 2>/dev/null | grep -q .; then
+                has_tests=true
+                break
+              fi
+            done
+            
+            if [ "$has_tests" = "false" ]; then
+              echo "⏭️ No Ginkgo test files found in: $TEST_DIRS"
+              echo "Falling back to standard go test..."
+              if go test -v -timeout=5m -parallel=4 ${{ matrix.test-suite.pattern }}; then
+                echo "✅ Tests passed successfully (go test fallback)"
+                break
+              fi
+            else
+              if ginkgo $GINKGO_FLAGS $TEST_DIRS; then
+                echo "✅ Ginkgo tests passed successfully"
+                break
+              fi
+            fi
+            
+            if [ $attempt -eq 2 ]; then
               echo "❌ Tests failed after 2 attempts"
               exit 1
             else
@@ -499,7 +530,7 @@ jobs:
           echo "- Go Version: ${{ needs.reliability-setup.outputs.go-version || 'N/A' }}" >> $GITHUB_STEP_SUMMARY
           echo "- Cache Strategy: Hierarchical with fallbacks" >> $GITHUB_STEP_SUMMARY
           echo "- Build Strategy: Intelligent chunking with timeout protection" >> $GITHUB_STEP_SUMMARY
-          echo "- Test Strategy: Parallel execution with retry logic" >> $GITHUB_STEP_SUMMARY
+          echo "- Test Strategy: Ginkgo v2 with parallel execution and retry logic" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
           
           echo "**Job Results:**" >> $GITHUB_STEP_SUMMARY
@@ -547,7 +578,7 @@ jobs:
             echo "- ✅ Optimized Go 1.25.x compatibility" >> $GITHUB_STEP_SUMMARY
             echo "- ✅ Enhanced cache reliability with fallbacks" >> $GITHUB_STEP_SUMMARY
             echo "- ✅ Intelligent build chunking prevents timeouts" >> $GITHUB_STEP_SUMMARY
-            echo "- ✅ Parallel testing with retry logic" >> $GITHUB_STEP_SUMMARY
+            echo "- ✅ Ginkgo v2 parallel testing with retry logic and randomization" >> $GITHUB_STEP_SUMMARY
             echo "- ✅ Comprehensive integration validation" >> $GITHUB_STEP_SUMMARY
             echo "✅ Reliability-optimized CI completed successfully!"
           fi

pkg/controllers/error_recovery_test.go

@@ -16,13 +16,10 @@ import (
 	"github.com/thc1006/nephoran-intent-operator/pkg/git"
 	"github.com/thc1006/nephoran-intent-operator/pkg/monitoring"
 	"github.com/thc1006/nephoran-intent-operator/pkg/nephio"
-	"github.com/thc1006/nephoran-intent-operator/pkg/resilience"
-	"github.com/thc1006/nephoran-intent-operator/pkg/security"
 	"github.com/thc1006/nephoran-intent-operator/pkg/shared"
 	"github.com/thc1006/nephoran-intent-operator/pkg/telecom"
 	"github.com/thc1006/nephoran-intent-operator/pkg/testutils"
 	corev1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"

pkg/controllers/networkintent_cleanup_table_driven_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"net/http"
 	"time"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -15,8 +14,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/types"
-	"k8s.io/client-go/tools/record"
 )
 
 // Constants used in cleanup tests

pkg/controllers/oran_controller.go

@@ -37,9 +37,9 @@ type OranAdaptorReconciler struct {
 
 	Scheme *runtime.Scheme
 
-	O1Adaptor *o1.O1Adaptor
+	O1Adaptor o1.O1AdaptorInterface
 
-	A1Adaptor *a1.A1Adaptor
+	A1Adaptor a1.A1AdaptorInterface
 }
 
 //+kubebuilder:rbac:groups=nephoran.com,resources=managedelements,verbs=get;list;watch;create;update;patch;delete

pkg/controllers/oran_controller_comprehensive_test.go

@@ -19,6 +19,7 @@ import (
 
 	nephoranv1 "github.com/thc1006/nephoran-intent-operator/api/v1"
 	"github.com/thc1006/nephoran-intent-operator/pkg/controllers/testutil"
+	"github.com/thc1006/nephoran-intent-operator/pkg/oran/a1"
 )
 
 // fakeO1Adaptor implements O1Adaptor for testing
@@ -40,6 +41,36 @@ func (f *fakeO1Adaptor) ApplyConfiguration(ctx context.Context, me *nephoranv1.M
 	return nil
 }
 
+func (f *fakeO1Adaptor) ClearAlarm(ctx context.Context, me *nephoranv1.ManagedElement, alarmID string) error {
+	f.callCount++
+	f.lastManagedElem = me
+
+	if f.shouldFail {
+		return fmt.Errorf("fake O1 alarm clear failure")
+	}
+	return nil
+}
+
+func (f *fakeO1Adaptor) Connect(ctx context.Context, me *nephoranv1.ManagedElement) error {
+	f.callCount++
+	f.lastManagedElem = me
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake O1 connection failure")
+	}
+	return nil
+}
+
+func (f *fakeO1Adaptor) Disconnect(ctx context.Context, me *nephoranv1.ManagedElement) error {
+	f.callCount++
+	f.lastManagedElem = me
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake O1 disconnect failure")
+	}
+	return nil
+}
+
 func (f *fakeO1Adaptor) Reset() {
 	f.shouldFail = false
 	f.callCount = 0
@@ -66,6 +97,42 @@ func (f *fakeA1Adaptor) ApplyPolicy(ctx context.Context, me *nephoranv1.ManagedE
 	return nil
 }
 
+func (f *fakeA1Adaptor) CreatePolicyInstance(ctx context.Context, policyTypeID int, instance *a1.A1PolicyInstance) error {
+	f.callCount++
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake A1 policy instance creation failure")
+	}
+	return nil
+}
+
+func (f *fakeA1Adaptor) CreatePolicyType(ctx context.Context, policyType *a1.A1PolicyType) error {
+	f.callCount++
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake A1 policy type creation failure")
+	}
+	return nil
+}
+
+func (f *fakeA1Adaptor) DeletePolicyInstance(ctx context.Context, policyTypeID int, instanceID string) error {
+	f.callCount++
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake A1 policy instance deletion failure")
+	}
+	return nil
+}
+
+func (f *fakeA1Adaptor) DeletePolicyType(ctx context.Context, policyTypeID int) error {
+	f.callCount++
+	
+	if f.shouldFail {
+		return fmt.Errorf("fake A1 policy type deletion failure")
+	}
+	return nil
+}
+
 func (f *fakeA1Adaptor) Reset() {
 	f.shouldFail = false
 	f.callCount = 0

pkg/nephio/blueprint/manager_comprehensive_test.go

@@ -33,6 +33,7 @@ import (
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/record"
@@ -62,7 +63,7 @@ func (mc *MockCache) GetInformer(ctx context.Context, obj client.Object, opts ..
 	return nil, nil
 }
 
-func (mc *MockCache) GetInformerForKind(ctx context.Context, gvk runtime.Object) (cache.Informer, error) {
+func (mc *MockCache) GetInformerForKind(ctx context.Context, gvk schema.GroupVersionKind, opts ...cache.InformerGetOption) (cache.Informer, error) {
 	return nil, nil
 }
 
@@ -78,6 +79,10 @@ func (mc *MockCache) IndexField(ctx context.Context, obj client.Object, field st
 	return nil
 }
 
+func (mc *MockCache) RemoveInformer(ctx context.Context, obj client.Object) error {
+	return nil
+}
+
 // MockManager implements the controller-runtime manager interface for testing
 type MockManager struct {
 	client client.Client

pkg/nephio/krm/runtime_comprehensive_test.go

@@ -238,9 +238,11 @@ func (r *MockKRMRuntime) registerStandardFunctions() {
 			{
 				Name:        "basic-labels",
 				Description: "Set basic labels on resources",
-				Config: &FunctionConfig{
-					Image: "gcr.io/kpt-fn/set-labels:v0.2.0",
-					ConfigMap: json.RawMessage(`{}`),
+				Config: map[string]interface{}{
+					"image": "gcr.io/kpt-fn/set-labels:v0.2.0",
+					"labels": map[string]interface{}{
+						"app": "test-app",
+					},
 				},
 				Input: []KRMResource{
 					generateTestResource("apps/v1", "Deployment", "test-deployment", "default"),

pkg/nephio/multicluster/chaos_resilience_test.go

@@ -38,10 +38,7 @@ import (
 )
 
 // Stub types to replace missing external dependencies
-type porchv1alpha1PackageRevision struct {
-	Name      string
-	Namespace string
-}
+// porchv1alpha1PackageRevision is defined in compliance_test.go
 
 type nephiov1alpha1ClusterDeploymentStatus struct {
 	Phase   string

pkg/nephio/multicluster/compliance_test.go

@@ -37,15 +37,31 @@ import (
 
 // Stub types to replace missing external dependencies
 type porchv1alpha1PackageRevision struct {
-	Name      string
-	Namespace string
+	metav1.TypeMeta   `json:",inline"`
+	metav1.ObjectMeta `json:"metadata,omitempty"`
+	
+	Spec   porchv1alpha1PackageRevisionSpec   `json:"spec,omitempty"`
+	Status porchv1alpha1PackageRevisionStatus `json:"status,omitempty"`
 }
 
-type nephiov1alpha1ClusterDeploymentStatus struct {
-	Phase   string
-	Message string
+type porchv1alpha1PackageRevisionSpec struct {
+	PackageName string                                   `json:"packageName,omitempty"`
+	Revision    string                                   `json:"revision,omitempty"`
+	Lifecycle   porchv1alpha1PackageRevisionLifecycle   `json:"lifecycle,omitempty"`
 }
 
+type porchv1alpha1PackageRevisionStatus struct {
+	// Add status fields if needed
+}
+
+type porchv1alpha1PackageRevisionLifecycle string
+
+const (
+	porchv1alpha1PackageRevisionLifecycleDraft = porchv1alpha1PackageRevisionLifecycle("Draft")
+)
+
+// nephiov1alpha1ClusterDeploymentStatus is defined in chaos_resilience_test.go
+
 // O-RAN Network Function Types
 type ORanFunctionType string
 

pkg/oran/a1/handlers_test.go

@@ -1037,8 +1037,8 @@ type MockA1Validator struct {
 }
 
 // MockA1Service implementations
-func (m *MockA1Service) CreatePolicyType(ctx context.Context, policyType *PolicyType) error {
-	args := m.Called(ctx, policyType)
+func (m *MockA1Service) CreatePolicyType(ctx context.Context, policyTypeID int, policyType *PolicyType) error {
+	args := m.Called(ctx, policyTypeID, policyType)
 	return args.Error(0)
 }
 
@@ -1087,6 +1087,11 @@ func (m *MockA1Service) RegisterConsumer(ctx context.Context, consumer *Consumer
 	return args.Error(0)
 }
 
+func (m *MockA1Service) DeleteEIJob(ctx context.Context, eiJobID string) error {
+	args := m.Called(ctx, eiJobID)
+	return args.Error(0)
+}
+
 func (m *MockA1Service) CreateEIType(ctx context.Context, eiTypeID string, eiType *EnrichmentInfoType) error {
 	args := m.Called(ctx, eiTypeID, eiType)
 	return args.Error(0)