chore: update dependencies and improve type safety

Olavo Parno · Olavo Parno · commit a2bad648e710 · 2025-03-10T10:16:11.000-03:00
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@
 
 | Statements                                                                                      | Branches                                                                                 | Functions                                                                                     | Lines                                                                                 |
 | ----------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------- |
-| ![Statements](https://img.shields.io/badge/statements-87.38%25-yellow.svg?style=flat&logo=jest) | ![Branches](https://img.shields.io/badge/branches-73.17%25-red.svg?style=flat&logo=jest) | ![Functions](https://img.shields.io/badge/functions-81.81%25-yellow.svg?style=flat&logo=jest) | ![Lines](https://img.shields.io/badge/lines-88%25-yellow.svg?style=flat&logo=jest) |
+| ![Statements](https://img.shields.io/badge/statements-87.5%25-yellow.svg?style=flat&logo=jest) | ![Branches](https://img.shields.io/badge/branches-73.17%25-red.svg?style=flat&logo=jest) | ![Functions](https://img.shields.io/badge/functions-81.81%25-yellow.svg?style=flat&logo=jest) | ![Lines](https://img.shields.io/badge/lines-88.11%25-yellow.svg?style=flat&logo=jest) |
 
 ## Table of Contents
 
diff --git a/package.json b/package.json
@@ -48,7 +48,7 @@
     ]
   },
   "peerDependencies": {
-    "react": "^17.0.2 || ^18"
+    "react": "^17.0.2 || ^18.0.0 || ^19.0.0"
   },
   "devDependencies": {
     "@babel/core": "^7.16.12",
@@ -88,6 +88,6 @@
     "standard-version": "^9.3.2",
     "tslib": "^2.3.1",
     "typescript": "^4.5.5",
-    "web-streams-polyfill": "^3.2.0"
+    "web-streams-polyfill": "^4.1.0"
   }
 }
diff --git a/src/__tests__/index.spec.ts b/src/__tests__/index.spec.ts
@@ -3,7 +3,7 @@
 import {
   ReadableStream,
   ReadableStreamDefaultReadResult,
-} from 'web-streams-polyfill/ponyfill';
+} from 'web-streams-polyfill';
 import { renderHook, act } from '@testing-library/react-hooks';
 import useDownloader, { jsDownload } from '../index';
 import { WindowDownloaderEmbedded } from '../types';
@@ -21,7 +21,8 @@ const expectedKeys = [
 beforeAll(() => {
   global.window.fetch = fetch as Extract<WindowOrWorkerGlobalScope, 'fetch'>;
   global.Response = Response;
-  global.ReadableStream = ReadableStream;
+  global.ReadableStream =
+    ReadableStream as unknown as typeof global.ReadableStream;
 });
 
 describe('useDownloader successes', () => {
@@ -240,10 +241,14 @@ describe('useDownloader failures', () => {
 
   describe('Tests without msSaveBlob', () => {
     beforeAll(() => {
-      (window as unknown as WindowDownloaderEmbedded).navigator.msSaveBlob =
-        undefined;
-      window.URL.createObjectURL = () => null;
-      window.URL.revokeObjectURL = () => null;
+      const currentWindow = window as unknown as WindowDownloaderEmbedded;
+
+      currentWindow.navigator.msSaveBlob = undefined;
+
+      if (currentWindow.URL) {
+        currentWindow.URL.createObjectURL = () => null;
+        currentWindow.URL.revokeObjectURL = () => null;
+      }
     });
 
     it('should test with URL and being revoked', async () => {
@@ -262,17 +267,22 @@ describe('useDownloader failures', () => {
     });
 
     it('should test with URL via webkitURL', () => {
-      window.URL = undefined;
-      window.webkitURL.createObjectURL = () => null;
+      const currentWindow = window as unknown as WindowDownloaderEmbedded;
 
-      const createObjectWebkitURLSpy = jest.spyOn(
-        window.webkitURL,
-        'createObjectURL'
-      );
+      currentWindow.URL = undefined;
 
-      jsDownload(new Blob(['abcde']), 'test');
+      if (currentWindow.webkitURL) {
+        currentWindow.webkitURL.createObjectURL = () => null;
+
+        const createObjectWebkitURLSpy = jest.spyOn(
+          window.webkitURL,
+          'createObjectURL'
+        );
+
+        jsDownload(new Blob(['abcde']), 'test');
 
-      expect(createObjectWebkitURLSpy).toHaveBeenCalled();
+        expect(createObjectWebkitURLSpy).toHaveBeenCalled();
+      }
     });
   });
 });
diff --git a/src/index.ts b/src/index.ts
@@ -98,11 +98,13 @@ export const jsDownload = (
     type: mime || 'application/octet-stream',
   });
 
+  const currentWindow = window as unknown as WindowDownloaderEmbedded;
+
   if (
-    typeof (window as unknown as WindowDownloaderEmbedded).navigator
+    typeof currentWindow.navigator
       .msSaveBlob !== 'undefined'
   ) {
-    return (window as unknown as WindowDownloaderEmbedded).navigator.msSaveBlob(
+    return currentWindow.navigator.msSaveBlob(
       blob,
       filename
     );
@@ -168,8 +170,8 @@ export default function useDownloader(
       'The user aborted a request.': 'Download timed out',
     };
     setError(() => {
-      const resolvedError = errorMap[err.message]
-        ? errorMap[err.message]
+      const resolvedError = errorMap[err.message as keyof typeof errorMap]
+        ? errorMap[err.message as keyof typeof errorMap]
         : err.message;
 
       return { errorMessage: resolvedError };
diff --git a/src/types.ts b/src/types.ts
@@ -79,9 +79,16 @@ export interface ResolverProps {
 }
 
 interface CustomNavigator extends Navigator {
-  msSaveBlob: (blob?: Blob, filename?: string) => boolean | NodeJS.Timeout;
+  msSaveBlob?: (blob?: Blob, filename?: string) => boolean | NodeJS.Timeout;
+}
+
+interface CustomURL extends URL {
+  createObjectURL: (blob: Blob) => string | null;
+  revokeObjectURL: (url: string) => void | null;
 }
 
 export interface WindowDownloaderEmbedded extends Window {
   navigator: CustomNavigator;
+  URL?: CustomURL
+  webkitURL?: CustomURL
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -17,7 +17,6 @@
     "noImplicitThis": true,
     "noImplicitAny": true,
     "strictNullChecks": true,
-    "suppressImplicitAnyIndexErrors": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "skipLibCheck": true,
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@`
`48`	`48`	`]`
`49`	`49`	`},`
`50`	`50`	`"peerDependencies": {`
`51`		`- "react": "^17.0.2 \|\| ^18"`
	`51`	`+ "react": "^17.0.2 \|\| ^18.0.0 \|\| ^19.0.0"`
`52`	`52`	`},`
`53`	`53`	`"devDependencies": {`
`54`	`54`	`"@babel/core": "^7.16.12",`
`@@ -88,6 +88,6 @@`
`88`	`88`	`"standard-version": "^9.3.2",`
`89`	`89`	`"tslib": "^2.3.1",`
`90`	`90`	`"typescript": "^4.5.5",`
`91`		`- "web-streams-polyfill": "^3.2.0"`
	`91`	`+ "web-streams-polyfill": "^4.1.0"`
`92`	`92`	`}`
`93`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,16 @@ export interface ResolverProps {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`interface CustomNavigator extends Navigator {`
`82`		`- msSaveBlob: (blob?: Blob, filename?: string) => boolean \| NodeJS.Timeout;`
	`82`	`+ msSaveBlob?: (blob?: Blob, filename?: string) => boolean \| NodeJS.Timeout;`
	`83`	`+}`
	`84`	`+`
	`85`	`+interface CustomURL extends URL {`
	`86`	`+ createObjectURL: (blob: Blob) => string \| null;`
	`87`	`+ revokeObjectURL: (url: string) => void \| null;`
`83`	`88`	`}`
`84`	`89`
`85`	`90`	`export interface WindowDownloaderEmbedded extends Window {`
`86`	`91`	`navigator: CustomNavigator;`
	`92`	`+ URL?: CustomURL`
	`93`	`+ webkitURL?: CustomURL`
`87`	`94`	`}`