TVB-3122. Fix Sonar warning: Unused private attributes.

Author: popaula937

tvb_framework/tvb/tests/framework/core/services/user_service_test.py

@@ -44,7 +44,7 @@
 TEST_DISPLAY_NAME = "test_name"
 TEST_EMAIL = "[email protected]"
 TEST_EMAIL2 = "[email protected]"
-TEST_PASS = "pass"
+TEST_PASS = "test_pass"
 TEST_PASSWORD = "test_password"
 TEST_ROLE = "user"
 TEST_USER = "test_user"
@@ -131,7 +131,7 @@ def test_create_user_empty_username(self):
         """
         Try to create a user with an empty username field.
         """
-        data = dict(username="", display_name=TEST_DISPLAY_NAME, password="test_pass", email=TEST_EMAIL, role=TEST_ROLE,
+        data = dict(username="", display_name=TEST_DISPLAY_NAME, password=TEST_PASS, email=TEST_EMAIL, role=TEST_ROLE,
                     comment="")
         with pytest.raises(UsernameException):
             self.user_service.create_user(**data)
@@ -140,7 +140,7 @@ def test_create_user_no_username(self):
         """
         Try to create a user with no username data.
         """
-        data = dict(password="test_pass", display_name=TEST_DISPLAY_NAME, email=TEST_EMAIL, role=TEST_ROLE, comment="")
+        data = dict(password=TEST_PASS, display_name=TEST_DISPLAY_NAME, email=TEST_EMAIL, role=TEST_ROLE, comment="")
         with pytest.raises(UsernameException):
             self.user_service.create_user(**data)
 
@@ -217,7 +217,7 @@ def test_is_username_valid(self):
         Test the method that checks if a userName is valid or not (if it already exists
         in the database the userName is not valid).
         """
-        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, "test_pass", TEST_EMAIL2, False, TEST_ROLE)
+        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, TEST_PASS, TEST_EMAIL2, False, TEST_ROLE)
         dao.store_entity(user)
         assert not self.user_service.is_username_valid(TEST_USER), "Should be False but got True"
         assert self.user_service.is_username_valid("test_user2"), "Should be True but got False"
@@ -226,42 +226,42 @@ def test_validate_user_happy_flow(self):
         """
         Standard flow for a validate user action.
         """
-        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, "test_pass", TEST_EMAIL2, False, TEST_ROLE)
+        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, TEST_PASS, TEST_EMAIL2, False, TEST_ROLE)
         dao.store_entity(user)
         assert self.user_service.validate_user(TEST_USER), "Validation failed when it shouldn't have."
 
     def test_validate_user_validated(self):
         """
         Flow for trying to validate a user that was already validated.
         """
-        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, "test_pass", TEST_EMAIL2, True, TEST_ROLE)
+        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, TEST_PASS, TEST_EMAIL2, True, TEST_ROLE)
         dao.store_entity(user)
         assert not self.user_service.validate_user(TEST_USER), "Validation invalid."
 
     def test_validate_user_non_existent(self):
         """
         Flow for trying to validate a user that doesn't exist in the database.
         """
-        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, "test_pass", TEST_EMAIL2, True, TEST_ROLE)
+        user = model_project.User(TEST_USER, TEST_DISPLAY_NAME, TEST_PASS, TEST_EMAIL2, True, TEST_ROLE)
         dao.store_entity(user)
         assert not self.user_service.validate_user("test_user2"), "Validation done even tho user is non-existent"
 
     def test_check_login_happy_flow(self):
         """
         Standard login flow with a valid username and password.
         """
-        user = model_project.User(TEST_USER, 'test_name', hash_password("test_pass"), TEST_EMAIL2, True,
+        user = model_project.User(TEST_USER, 'test_name', hash_password(TEST_PASS), TEST_EMAIL2, True,
                                   TEST_ROLE)
         dao.store_entity(user)
         available_users = dao.get_all_users()
         assert 2 == len(available_users)
-        assert self.user_service.check_login(TEST_USER, "test_pass") is not None, "Login failed when it shouldn't."
+        assert self.user_service.check_login(TEST_USER, TEST_PASS) is not None, "Login failed when it shouldn't."
 
     def test_check_login_bad_pass(self):
         """
         Flow for entering a bad/invalid password.
         """
-        user = model_project.User(TEST_USER, 'test_user_name', hash_password("test_pass"), TEST_EMAIL2, True,
+        user = model_project.User(TEST_USER, 'test_user_name', hash_password(TEST_PASS), TEST_EMAIL2, True,
                                   TEST_ROLE)
         dao.store_entity(user)
         available_users = dao.get_all_users()
@@ -272,12 +272,12 @@ def test_check_login_bad_user(self):
         """
         Flow for entering a bad/invalid username.
         """
-        user = model_project.User(TEST_USER, 'test_name', hash_password("test_pass"), TEST_EMAIL2, True,
+        user = model_project.User(TEST_USER, 'test_name', hash_password(TEST_PASS), TEST_EMAIL2, True,
                                   TEST_ROLE)
         dao.store_entity(user)
         available_users = dao.get_all_users()
         assert 2 == len(available_users)
-        assert self.user_service.check_login("bad_user", "test_pass") is None, "Login succeeded with bad userName."
+        assert self.user_service.check_login("bad_user", TEST_PASS) is None, "Login succeeded with bad userName."
 
     def test_get_users_for_project(self):
         """

tvb_storage/tvb/storage/h5/file/hdf5_storage_manager.py

@@ -57,7 +57,6 @@ class HDF5StorageManager(object):
     """
     This class is responsible for saving / loading data in HDF5 file / format.
     """
-    __file_title_ = "TVB data file"
     __storage_full_name = None
     __hfd5_file = None
 
@@ -77,7 +76,6 @@ def __init__(self, storage_full_name):
             raise FileStructureException("Please provide the file name where to store data")
 
         self.__storage_full_name = storage_full_name
-        self.__buffer_array = None
         self.data_buffers = {}
         self.data_encryption_handler = encryption_handler