Some exif_* functions are missed

[peter279k]

As title, some exif_* functions are missed.

These functions are as follows:

• exif_imagetype

exif_imagetype('/not/found')
PHP Warning:  exif_imagetype(/not/found): failed to open stream: No such file or directory

• exif_thumbnail

exif_thumbnail('/path/to/image.jpg');
PHP Warning:  exif_thumbnail(): Unable to open file

• exif_read_data

PHP Warning:  exif_read_data(): Unable to open file 

References

• https://www.php.net/manual/en/book.exif.php

[nagmat84]

Any progress on this issue? A stumbled across the same problem a few minutes ago.

[shish]

These look tricky D:

exit_imagetype
When a correct signature is found, the appropriate constant value will be returned otherwise the return value is false

So these return false for both "file does not exist" (which should definitely be an exception) and "file is fine but I don't know what type it is" (in which case it seems like false is a valid value, though I personally would've gone with null)

It is possible that exif_thumbnail() cannot create an image but can determine its size. In this case, the return value is false but width and height are set.

So this function can half-succeed, even when returning false D:

exif_read_data
If no data can be returned, exif_read_data() will return false

sounds like "false" can mean either "file doesn't exist" (which should really be an exception) or "file is fine, but contains no metadata" (which should really be an empty array)?

I think to support these we'd need to add special-case wrappers which do things like checking for "file does not exist" manually (and throw an exception in that case), but then return the false-y values in cases where the false-y values are not-exceptional. But then that gets even more tricky, because we might not catch every possible error condition, and we get into a situation where some errors are exceptions, some errors return false, and some successes return false...