Image upload data-match

[igiona]

Hi,

looking at the file upload implementation in: https://github.com/thedjnK/AuTerm/blob/main/plugins/mcumgr/smp_group_img_mgmt.cpp , and in particular at the match field in the file-upload response parsing:

if (key == "match")
{
    bool match_value = reader.toBool();
 
    if (match_value == true)
    {
        *match = MATCH_FAILED;
    }
    else
    {
        *match = MATCH_PASSED;
    }
}

I believe that this logic is wrong, or at least doesn't match the Zephyr implementation, where the match field is set to true when the SHA verification passes: https://github.com/zephyrproject-rtos/zephyr/blob/44bbc13394d334862995bb58a3c64da1bdd6d00d/subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt.c#L889-L913

Is the AuTerm implementation simply wrong, or there is more to it?

[thedjnK]

that does indeed seem to be an issue yes

[thedjnK]

Fixed in 0.37