Test negative cases refactoring

thedoorbell · thedoorbell · commit 2ccb4685c6ad · 2025-09-30T21:18:55.000+03:00
diff --git a/__fixtures__/expected-ru-hexlet-io-courses.html b/__fixtures__/expected-ru-hexlet-io-courses.html
@@ -1,32 +1,17 @@
-<!DOCTYPE html>
-<html lang="ru">
-  <head>
-    <meta charset="utf-8" />
+<!DOCTYPE html><html lang="ru"><head>
+    <meta charset="utf-8">
     <title>Курсы по программированию Хекслет</title>
-    <link
-      rel="stylesheet"
-      media="all"
-      href="https://cdn2.hexlet.io/assets/menu.css"
-    />
-    <link
-      rel="stylesheet"
-      media="all"
-      href="ru-hexlet-io-courses_files/ru-hexlet-io-assets-application.css"
-    />
-    <link
-      href="ru-hexlet-io-courses_files/ru-hexlet-io-courses.html"
-      rel="canonical"
-    />
+    <link rel="stylesheet" media="all" href="https://cdn2.hexlet.io/assets/menu.css">
+    <link rel="stylesheet" media="all" href="ru-hexlet-io-courses_files/ru-hexlet-io-assets-application.css">
+    <link href="ru-hexlet-io-courses_files/ru-hexlet-io-courses.html" rel="canonical">
   </head>
   <body>
-    <img
-      src="ru-hexlet-io-courses_files/ru-hexlet-io-assets-professions-nodejs.png"
-      alt="Иконка профессии Node.js-программист"
-    />
+    <img src="ru-hexlet-io-courses_files/ru-hexlet-io-assets-professions-nodejs.png" alt="Иконка профессии Node.js-программист">
     <h3>
       <a href="/professions/nodejs">Node.js-программист</a>
     </h3>
     <script src="https://js.stripe.com/v3/"></script>
     <script src="ru-hexlet-io-courses_files/ru-hexlet-io-packs-js-runtime.js"></script>
-  </body>
-</html>
+  
+
+</body></html>
diff --git a/__tests__/page-loader.test.js b/__tests__/page-loader.test.js
@@ -59,30 +59,45 @@ test('page-loader', async () => {
   expect(downloadedScript).toBe('js {}')
 })
 
-test('page-loader: network errors', async () => {
-  nock('https://ru.hexlet.io')
-    .get('/courses')
-    .reply(404)
-  nock('https://ru.hexlet.io')
-    .get('/assets/professions/nodejs.png')
-    .reply(500)
+const networkErrors = [
+  {
+    url: 'https://ru.hexlet.io/courses',
+    status: 404,
+    expected: 'Cant get https://ru.hexlet.io/courses - Request failed with status code 404',
+  },
+  {
+    url: 'https://ru.hexlet.io/assets/professions/nodejs.png',
+    status: 500,
+    expected: 'Cant get https://ru.hexlet.io/assets/professions/nodejs.png - Request failed with status code 500',
+  },
+]
 
-  await expect(downloadPage('https://ru.hexlet.io/courses', tempDir))
-    .rejects
-    .toThrow('Cant get https://ru.hexlet.io/courses - Request failed with status code 404')
-  await expect(downloadPage('https://ru.hexlet.io/assets/professions/nodejs.png', tempDir))
-    .rejects
-    .toThrow('Cant get https://ru.hexlet.io/assets/professions/nodejs.png - Request failed with status code 500')
-})
+test.each(networkErrors)('page-loader: network error $status',
+  async ({ url, status, expected }) => {
+    nock('https://ru.hexlet.io')
+      .get(new URL(url).pathname)
+      .reply(status)
 
-test('page-loader: file operation errors', async () => {
-  nock('https://ru.hexlet.io')
-    .get('/courses')
-    .times(2)
-    .reply(200, html)
+    await expect(downloadPage(url, tempDir)).rejects.toThrow(expected)
+  })
 
-  await expect(downloadPage('https://ru.hexlet.io/courses', '/unexisting'))
-    .rejects.toThrow('ERROR: No such output directory - /unexisting')
-  await expect(downloadPage('https://ru.hexlet.io/courses', '/root'))
-    .rejects.toThrow('ERROR: No access to output directory - /root')
-})
+const fileErrors = [
+  {
+    path: '/unexisting',
+    expected: 'ERROR: No such output directory - /unexisting',
+  },
+  {
+    path: '/root',
+    expected: 'ERROR: No access to output directory - /root',
+  },
+]
+
+test.each(fileErrors)('page-loader: file operation error on path $path',
+  async ({ path, expected }) => {
+    nock('https://ru.hexlet.io')
+      .get('/courses')
+      .reply(200, html)
+
+    await expect(downloadPage('https://ru.hexlet.io/courses', path))
+      .rejects.toThrow(expected)
+  })
