fix(telemetry): keep shared telemetry tests isolated

Author: rodboev

src/services/telemetry/telemetry.ts

@@ -37,15 +37,14 @@ function hasConsent(): boolean {
   return value;
 }
 
-export function __resetTelemetryStateForTesting(): void {
-  if (process.env.NODE_ENV !== 'test') {
-    return;
-  }
+export function __resetTelemetryForTests(): void {
   client = null;
   isShutdown = false;
   consentCache = null;
 }
 
+export const __resetTelemetryStateForTesting = __resetTelemetryForTests;
+
 function getClient(): PostHog {
   if (!client) {
     client = new PostHog(getTelemetryApiKey(), {

tests/telemetry/telemetry-client.test.ts

@@ -1,7 +1,8 @@
-import { describe, it, expect, mock, beforeAll, afterAll, beforeEach, afterEach } from 'bun:test';
+import { describe, it, expect, beforeAll, afterAll, beforeEach, afterEach } from 'bun:test';
 import { mkdtempSync, rmSync } from 'fs';
 import { tmpdir } from 'os';
 import { join } from 'path';
+import { postHogConstructorCalls, postHogCaptureCalls } from '../preload';
 
 /**
  * Guards the PostHog client construction options. The posthog-node SDK stamps
@@ -10,25 +11,9 @@ import { join } from 'path';
  * mocked so no real client (and no network) is ever created.
  */
 
-type ConstructorCall = { apiKey: string; options: Record<string, unknown> };
-const constructorCalls: ConstructorCall[] = [];
-const captureCalls: Array<Record<string, unknown>> = [];
-
-mock.module('posthog-node', () => ({
-  PostHog: class {
-    constructor(apiKey: string, options: Record<string, unknown>) {
-      constructorCalls.push({ apiKey, options });
-    }
-    capture(payload: Record<string, unknown>): void {
-      captureCalls.push(payload);
-    }
-    async shutdown(): Promise<void> {}
-  },
-}));
-
 const {
   captureEvent,
-  __resetTelemetryStateForTesting,
+  __resetTelemetryForTests,
 } = await import('../../src/services/telemetry/telemetry');
 
 let tempDir: string;
@@ -52,15 +37,15 @@ beforeAll(() => {
 });
 
 beforeEach(() => {
-  constructorCalls.length = 0;
-  captureCalls.length = 0;
-  __resetTelemetryStateForTesting();
+  postHogConstructorCalls.length = 0;
+  postHogCaptureCalls.length = 0;
+  __resetTelemetryForTests();
   process.env.CLAUDE_MEM_TELEMETRY = '1';
   delete process.env.DO_NOT_TRACK;
 });
 
 afterEach(() => {
-  __resetTelemetryStateForTesting();
+  __resetTelemetryForTests();
 });
 
 afterAll(() => {
@@ -75,29 +60,29 @@ describe('PostHog client construction', () => {
   it('constructs the client with disableGeoip: false so ingest-side geolocation works', () => {
     captureEvent('test_event');
 
-    expect(constructorCalls.length).toBe(1);
-    expect(constructorCalls[0].options.disableGeoip).toBe(false);
+    expect(postHogConstructorCalls.length).toBe(1);
+    expect(postHogConstructorCalls[0].options.disableGeoip).toBe(false);
   });
 
   it('reuses the client and queues the capture', () => {
     captureEvent('test_event_2');
 
-    expect(constructorCalls.length).toBe(1);
-    expect(captureCalls.length).toBe(1);
-    expect(captureCalls[0].event).toBe('test_event_2');
+    expect(postHogConstructorCalls.length).toBe(1);
+    expect(postHogCaptureCalls.length).toBe(1);
+    expect(postHogCaptureCalls[0].event).toBe('test_event_2');
   });
 
   it('re-resolves consent when the env override flips within the cache ttl window', () => {
     process.env.CLAUDE_MEM_TELEMETRY = '0';
     captureEvent('opted_out_event');
-    expect(constructorCalls.length).toBe(0);
-    expect(captureCalls.length).toBe(0);
+    expect(postHogConstructorCalls.length).toBe(0);
+    expect(postHogCaptureCalls.length).toBe(0);
 
     process.env.CLAUDE_MEM_TELEMETRY = '1';
     captureEvent('opted_in_event');
 
-    expect(constructorCalls.length).toBe(1);
-    expect(captureCalls.length).toBe(1);
-    expect(captureCalls[0].event).toBe('opted_in_event');
+    expect(postHogConstructorCalls.length).toBe(1);
+    expect(postHogCaptureCalls.length).toBe(1);
+    expect(postHogCaptureCalls[0].event).toBe('opted_in_event');
   });
 });