use_netgroups and ldap_group_membership compatibility

Author: adamruzicka

plugins/modules/auth_source_ldap.py

@@ -101,6 +101,12 @@
     description: Base DN where groups reside.
     required: false
     type: str
+  use_netgroups:
+    description:
+      - Whether to use NIS netgroups instead of posix groups, not valid for I(server_type=active_directory)
+      - "Deprecated: The use_netgroups parameter is deprecated with Foreman 3.16 in favor of I(ldap_group_membership) and will be removed in a future release."
+    required: false
+    type: bool
   ldap_group_membership:
     description: Which group membership method to use, not valid for I(server_type=active_directory). Option I(rfc4519) is valid only for I(server_type=posix).
     required: false
@@ -215,17 +221,26 @@ def main():
             groups_base=dict(),
             server_type=dict(choices=["free_ipa", "active_directory", "posix"]),
             ldap_filter=dict(),
+            use_netgroups=dict(type='bool'),
             ldap_group_membership=dict(choices=["posix", "nis_netgroups", "rfc4519"]),
         ),
         required_if=[['onthefly_register', True, ['attr_login', 'attr_firstname', 'attr_lastname', 'attr_mail']]],
     )
 
     # additional parameter checks
-    server_type = module.foreman_params['server_type']
+    use_netgroups = module.foreman_params.get('use_netgroups')
+    ldap_group_membership = module.foreman_params.get('ldap_group_membership')
+    if use_netgroups is not None:
+      expected_ldap_group_membership = ['nis_netgroups'] if use_netgroups == True else ['posix', 'rfc4519']
+      if ldap_group_membership is None:
+        module.foreman_params['ldap_group_membership'] = expected_ldap_group_membership[0]
+      elif ldap_group_membership not in expected_ldap_group_membership:
+        module.fail_json(msg=f'ldap_group_membership={{ ldap_group_membership }} cannot be used when use_netgroups={{ use_netgroups }}')
+
+    server_type = module.foreman_params.get('server_type', 'posix')
     if 'ldap_group_membership' in module.foreman_params and server_type == 'active_directory'
         module.fail_json(msg='ldap_group_membership cannot be used when server_type=active_directory')
 
-
     if 'ldap_group_membership' in module.foreman_params and module.foreman_params['ldap_group_membership'] == 'rfc4519' and server_type != 'posix':
         module.fail_json(msg=f'ldap_group_membership=rfc4519 cannot be used when server_type={{ server_type }}')