Fixes #XXXXX - Track and surface unrecognized Smart Proxy features

When a Smart Proxy reports features that Foreman doesn't recognize
(e.g. a plugin installed on the proxy but not on the server), those
features were silently dropped. Now they are persisted and surfaced
to the user via the API, UI, and server logs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: adamruzicka

app/models/smart_proxy.rb

@@ -6,6 +6,8 @@ class SmartProxy < ApplicationRecord
   include Taxonomix
   include Parameterizable::ByIdName
 
+  serialize :unrecognized_features, Array
+
   validates_lengths_from_database
   before_destroy EnsureNotUsedBy.new(:hosts, :hostgroups, :subnets, :domains, [:puppet_ca_hosts, :hosts], [:puppet_ca_hostgroups, :hostgroups], :realms)
   # TODO check if there is a way to look into the tftp_id too
@@ -168,10 +170,16 @@ def associate_features
       end
 
       feature_name_map = Feature.name_map
-      valid_features = reply.select { |feature, options| feature_name_map.key?(feature) }
+      valid_features, unknown_features = reply.partition { |feature, _options| feature_name_map.key?(feature) }
+      valid_features = valid_features.to_h
+      self.unrecognized_features = unknown_features.map(&:first)
 
       if valid_features.any?
         SmartProxyFeature.import_features(self, valid_features)
+        if unrecognized_features.any?
+          logger.warn("Proxy #{name} has features not recognized by Foreman: #{unrecognized_features.to_sentence}. "\
+                      "If these features come from a Smart Proxy plugin, make sure Foreman has the plugin installed too.")
+        end
       else
         smart_proxy_features.clear
         if reply.any?

app/views/api/v2/smart_proxies/main.json.rabl

@@ -2,7 +2,7 @@ object @smart_proxy
 
 extends "api/v2/smart_proxies/base"
 
-attributes :created_at, :updated_at, :hosts_count
+attributes :created_at, :updated_at, :hosts_count, :unrecognized_features
 
 child :smart_proxy_features => :features do
   attributes :capabilities

app/views/smart_proxies/index.html.erb

@@ -20,7 +20,12 @@
         <td class="nbsp ellipsis"><%= link_to_if_authorized proxy.name, {:action => :show, :id => proxy} %></td>
         <td class="hidden-sm hidden-xs nbsp ellipsis"><%= generate_links_for(proxy.locations).html_safe %></td>
         <td class="hidden-sm hidden-xs nbsp ellipsis"><%= generate_links_for(proxy.organizations).html_safe %></td>
-        <td class="ellipsis"><%= proxy.features.map(&:name).sort.to_sentence %></td>
+        <td class="ellipsis">
+          <%= proxy.features.map(&:name).sort.to_sentence %>
+          <% if proxy.unrecognized_features.present? %>
+            <span class="pficon pficon-warning-triangle-o" title="<%= _('This proxy has features not recognized by Foreman: %s') % proxy.unrecognized_features.to_sentence %>"></span>
+          <% end %>
+        </td>
         <td>
           <span class="proxy-show-status"><%= spinner %></span>
         </td>

app/views/smart_proxies/show.html.erb

@@ -64,6 +64,22 @@
           <% end %>
         </div>
 
+        <% if @smart_proxy.unrecognized_features.present? %>
+          <div class="row">
+            <div class="col-md-4">
+              <strong><span class="pficon pficon-warning-triangle-o"></span> <%= _('Unrecognized features') %></strong>
+            </div>
+            <div class="col-md-8">
+              <p><%= _('The following features are reported by this Smart Proxy but are not recognized by Foreman. The corresponding Foreman plugins may not be installed.') %></p>
+              <ul>
+                <% @smart_proxy.unrecognized_features.each do |feature| %>
+                  <li><%= h(feature) %></li>
+                <% end %>
+              </ul>
+            </div>
+          </div>
+        <% end %>
+
         <div class="row">
           <div class="col-md-4"></div>
           <div class="col-md-8">

db/migrate/20260610120000_add_unrecognized_features_to_smart_proxies.rb

@@ -0,0 +1,5 @@
+class AddUnrecognizedFeaturesToSmartProxies < ActiveRecord::Migration[7.0]
+  def change
+    add_column :smart_proxies, :unrecognized_features, :text
+  end
+end

test/controllers/api/v2/smart_proxies_controller_test.rb

@@ -202,6 +202,31 @@ class Api::V2::SmartProxiesControllerTest < ActionController::TestCase
   #   assert_response :unprocessable_entity
   # end
 
+  test "should include unrecognized_features in show response" do
+    features_with_unknown = Hash[Feature.name_map.keys.collect { |f| [f, {'state' => 'running'}] }]
+    features_with_unknown['unknown_plugin'] = {'state' => 'running'}
+    ProxyAPI::V2::Features.any_instance.stubs(:features).returns(features_with_unknown)
+    proxy = smart_proxies(:one)
+    proxy.save!
+    get :show, params: { :id => proxy.to_param }
+    assert_response :success
+    show_response = ActiveSupport::JSON.decode(@response.body)
+    assert_equal ['unknown_plugin'], show_response['unrecognized_features']
+  end
+
+  test "should include unrecognized_features in index response" do
+    features_with_unknown = Hash[Feature.name_map.keys.collect { |f| [f, {'state' => 'running'}] }]
+    features_with_unknown['unknown_plugin'] = {'state' => 'running'}
+    ProxyAPI::V2::Features.any_instance.stubs(:features).returns(features_with_unknown)
+    proxy = smart_proxies(:one)
+    proxy.save!
+    get :index
+    assert_response :success
+    index_response = ActiveSupport::JSON.decode(@response.body)
+    proxy_response = index_response['results'].find { |p| p['id'] == proxy.id }
+    assert_equal ['unknown_plugin'], proxy_response['unrecognized_features']
+  end
+
   test "should refresh smart proxy features" do
     proxy = smart_proxies(:one)
     post :refresh, params: { :id => proxy }

test/models/smart_proxy_test.rb

@@ -115,6 +115,36 @@ class SmartProxyTest < ActiveSupport::TestCase
       assert_equal(error_message, proxy.errors[:base].first)
     end
 
+    test "should store unrecognized features when proxy has mix of known and unknown" do
+      ProxyAPI::V2::Features.any_instance.stubs(:features).returns(
+        'tftp' => {'state' => 'running'},
+        'unknown_plugin' => {'state' => 'running'},
+        'another_unknown' => {'state' => 'running'}
+      )
+      proxy = FactoryBot.build(:smart_proxy)
+      assert proxy.save
+      proxy.reload
+      assert_include(proxy.features, features(:tftp))
+      assert_equal %w[unknown_plugin another_unknown].sort, proxy.unrecognized_features.sort
+    end
+
+    test "should clear unrecognized features when all proxy features are known" do
+      ProxyAPI::V2::Features.any_instance.stubs(:features).returns(
+        'tftp' => {'state' => 'running'}
+      )
+      proxy = FactoryBot.build(:smart_proxy)
+      assert proxy.save
+      proxy.reload
+      assert_empty proxy.unrecognized_features
+    end
+
+    test "should populate unrecognized features even when no valid features exist" do
+      proxy = SmartProxy.new(:name => 'Proxy', :url => 'https://some.where.net:8443')
+      ProxyAPI::V2::Features.any_instance.stubs(:features).returns({'unknown_feature' => {'state' => 'running'}})
+      refute proxy.save
+      assert_equal ['unknown_feature'], proxy.unrecognized_features
+    end
+
     test "can import and access capabilities and settings" do
       ProxyAPI::V2::Features.any_instance.stubs(:features).returns(:tftp => {:settings => {:foo => :bar}, :capabilities => ['FOO'], :state => 'running'})
       proxy = FactoryBot.build(:smart_proxy)