Skip to content

Commit a51d9dd

Browse files
committed
address code review
1 parent 2644322 commit a51d9dd

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

app/controllers/api/v2/preupgrade_report_entries_controller.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def index
3232
param :excluded_ids, Array, required: false, desc: N_('Array of excluded entry IDs')
3333
def bulk_remediate
3434
entries = filtered_remediation_entries
35-
remediation_ids = entries.pluck(:id).sort
35+
remediation_ids = entries.pluck(:id)
3636

3737
if remediation_ids.empty?
3838
return render json: { error: _('No fixable entries found matching the selection.') },
@@ -91,9 +91,7 @@ def filtered_remediation_entries
9191

9292
def target_host_ids(entries)
9393
host_ids = entries.pluck(:host_id).uniq.compact
94-
9594
host_ids = [@preupgrade_report.host_id].compact if host_ids.empty? && @preupgrade_report
96-
9795
host_ids
9896
end
9997

test/functional/api/v2/preupgrade_report_entries_controller_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ class PreupgradeReportEntriesControllerTest < ActionController::TestCase
214214
end
215215

216216
test 'triggers job invocation for all fixable entries' do
217-
expected_ids = [@entry1.id, @entry2.id, @entry3.id].sort.join(',')
217+
expected_ids = [@entry1.id, @entry2.id, @entry3.id].join(',')
218218

219219
JobInvocationComposer.expects(:for_feature)
220220
.with('leapp_remediation_plan', [@host.id], { 'remediation_ids' => expected_ids })
@@ -227,7 +227,7 @@ class PreupgradeReportEntriesControllerTest < ActionController::TestCase
227227
end
228228

229229
test 'respects the excluded_ids parameter' do
230-
expected_ids = [@entry1.id, @entry3.id].sort.join(',')
230+
expected_ids = [@entry1.id, @entry3.id].join(',')
231231

232232
JobInvocationComposer.expects(:for_feature)
233233
.with('leapp_remediation_plan', [@host.id], { 'remediation_ids' => expected_ids })

0 commit comments

Comments
 (0)