Refactor candlepin_database_test to be more explicit in testing

Author: ekohl

definitions/features/candlepin_database.rb

@@ -30,8 +30,11 @@ def check_option_using_cpdb_help(option_name, parent_cmd = '')
 
   private
 
+  def raw_config
+    File.read(CANDLEPIN_DB_CONFIG)
+  end
+
   def load_configuration
-    raw_config = File.read(CANDLEPIN_DB_CONFIG)
     full_config = Hash[raw_config.scan(/(^[^#\n][^=]*)=(.*)/)]
     uri_regexp = %r{://(([^/:]*):?([^/]*))/([^?]*)\??(ssl=([^&]*))?}
     url = full_config['jpa.config.hibernate.connection.url']

test/definitions/features/candlepin_database_test.rb

@@ -1,39 +1,39 @@
 require 'test_helper'
-require 'minitest/stub_const'
 
 describe Features::CandlepinDatabase do
   include DefinitionsTestHelper
   subject { Features::CandlepinDatabase.new }
-  let(:subject_ins) { Features::CandlepinDatabase.any_instance }
 
   let(:cp_config_dir) do
     File.expand_path('../../support', __dir__)
   end
 
-  def stub_with_ssl_config(&block)
-    Features::CandlepinDatabase.stub_const(:CANDLEPIN_DB_CONFIG,
-      cp_config_dir + '/candlepin_with_ssl.conf', &block)
-  end
-
-  def stub_without_ssl_config(&block)
-    Features::CandlepinDatabase.stub_const(:CANDLEPIN_DB_CONFIG,
-      cp_config_dir + '/candlepin_without_ssl.conf', &block)
+  def stub_config(&block)
+    subject.stub(:raw_config, File.read(File.join(cp_config_dir, config)), &block)
   end
 
   describe '.configuration' do
-    it 'The url includes ssl attributes when ssl is enabled' do
-      stub_with_ssl_config do
-        url = subject.configuration['url']
-        assert_includes url, 'ssl=true'
-        assert_includes url, 'sslrootcert=/usr/share/foreman/root.crt'
+    let(:configuration) { subject.configuration }
+
+    describe 'with ssl' do
+      let(:config) { 'candlepin_with_ssl.conf' }
+
+      it 'sets ssl to true' do
+        stub_config do
+          assert_includes configuration['url'], 'ssl=true'
+          assert configuration['ssl']
+        end
       end
     end
 
-    it 'The url does not include ssl attributes when ssl is disabled' do
-      stub_without_ssl_config do
-        url = subject.configuration['url']
-        refute_includes url, 'ssl=true'
-        refute_includes url, 'sslrootcert=/usr/share/foreman/root.crt'
+    describe 'without ssl' do
+      let(:config) { 'candlepin_without_ssl.conf' }
+
+      it 'sets ssl to false' do
+        stub_config do
+          refute_includes configuration['url'], 'ssl=true'
+          refute configuration['ssl']
+        end
       end
     end
   end