Fixes #39154 - Add tests for canceling and aborting tasks#1023
Merged
Lukshio merged 1 commit intotheforeman:masterfrom Mar 18, 2026
Merged
Fixes #39154 - Add tests for canceling and aborting tasks#1023Lukshio merged 1 commit intotheforeman:masterfrom
Lukshio merged 1 commit intotheforeman:masterfrom
Conversation
Contributor
|
If I'm reading it correctly then all the api calls it would make are mocked, correct? So this doesn't really depend on the foreman-tasks#799, right? |
Lukshio
requested changes
Mar 17, 2026
Contributor
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Hi, if the test should be designed just to verify if the api call was invoked, then I find it ok. But I would rename the tests to be more accurate.
webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js
Outdated
Show resolved
Hide resolved
webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js
Outdated
Show resolved
Hide resolved
webpack/JobInvocationDetail/__tests__/TemplateInvocation.test.js
Outdated
Show resolved
Hide resolved
kmalyjur
force-pushed
the
cancel-abort-tests
branch
from
fc1a651 to
c1ca07f
Compare
Contributor
Author
@adamruzicka You're right, it's just connected. |
Contributor
|
Thanks @kmalyjur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the 'Cancel Task' and 'Abort Task' actions in the job invocation host table.
Depends on theforeman/foreman-tasks#799.