Remove After=foreman.target to fix systemd ordering cycles

After=foreman.target was added in 805217d to ensure systemctl stop
foreman.target blocks until all constituent services fully stop, preventing
a rapid stop+start race. However, every service is also WantedBy=foreman.target,
making After=foreman.target inherently circular: foreman.target cannot finish
starting until its Wants are satisfied, but those services cannot start until
foreman.target has started.

This caused both start and stop ordering cycles, which systemd resolved by
dropping jobs — leading to unclean postgresql shutdowns, stale postmaster.pid
files, and the very race condition the original fix was trying to prevent.

Remove After=foreman.target from all services. Stop ordering is preserved
through inter-service After= relationships: all application services are
After=redis.service postgresql.service (reversed: redis/postgresql stop after
all application services). PartOf=foreman.target ensures services stop when
foreman.target stops, and systemctl stop foreman.target waits for the full
PartOf-propagated transaction to complete.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

src/roles/candlepin/tasks/main.yml

@@ -97,7 +97,7 @@
         [Unit]
         PartOf=foreman.target
         Wants=redis.service postgresql.service
-        After=foreman.target redis.service postgresql.service
+        After=redis.service postgresql.service
         [Service]
         TimeoutStartSec=300
     healthcheck: curl --fail --insecure https://localhost:23443/candlepin/status

src/roles/foreman/tasks/main.yaml

@@ -127,7 +127,7 @@
         [Unit]
         PartOf=foreman.target
         Wants=redis.service postgresql.service candlepin.service
-        After=foreman.target redis.service postgresql.service candlepin.service
+        After=redis.service postgresql.service candlepin.service
   notify: Restart foreman
 
 - name: Deploy Dynflow Container
@@ -162,7 +162,7 @@
         [Unit]
         PartOf=foreman.target
         Wants=redis.service postgresql.service
-        After=foreman.target redis.service postgresql.service
+        After=redis.service postgresql.service
       - |
         [Service]
         Restart=on-failure
@@ -207,7 +207,6 @@
       - |
         [Unit]
         PartOf=foreman.target
-        After=foreman.target
         StartLimitIntervalSec=0
       - |
         [Service]

src/roles/foreman/templates/foreman-recurring@.timer.j2

@@ -1,7 +1,6 @@
 [Unit]
 Description=Timer for Foreman recurring: {{ item.rake }}
 PartOf=foreman.target
-After=foreman.target
 
 [Timer]
 Unit=foreman-recurring@{{ item.instance }}.service

src/roles/foreman_proxy/tasks/main.yaml

@@ -34,7 +34,6 @@
         WantedBy=default.target foreman.target
         [Unit]
         PartOf=foreman.target
-        After=foreman.target
   notify: Restart Foreman Proxy
 
 - name: Create foreman-proxy.container.d folder

src/roles/postgresql/tasks/main.yml

@@ -43,7 +43,6 @@
         WantedBy=default.target foreman.target
         [Unit]
         PartOf=foreman.target
-        After=foreman.target
 
 - name: Configure SSL certificates
   when:

src/roles/pulp/tasks/main.yaml

@@ -119,7 +119,7 @@
         [Unit]
         PartOf=foreman.target
         Wants=redis.service postgresql.service
-        After=foreman.target redis.service postgresql.service
+        After=redis.service postgresql.service
         [Service]
         Restart=always
         RestartSec=3
@@ -150,7 +150,7 @@
         [Unit]
         PartOf=foreman.target
         Wants=redis.service postgresql.service
-        After=foreman.target redis.service postgresql.service
+        After=redis.service postgresql.service
         [Service]
         Restart=always
         RestartSec=3
@@ -181,7 +181,7 @@
         [Unit]
         PartOf=pulp-worker.target foreman.target
         Wants=redis.service postgresql.service
-        After=foreman.target redis.service postgresql.service
+        After=redis.service postgresql.service
         [Service]
         Restart=always
         RestartSec=3

src/roles/redis/tasks/main.yaml

@@ -30,7 +30,6 @@
         WantedBy=default.target foreman.target
         [Unit]
         PartOf=foreman.target
-        After=foreman.target
 
 - name: Run daemon reload
   ansible.builtin.systemd: