Skip to content

Commit c09f83c

Browse files
jeremylenzclaude
andcommitted
Address review feedback: remove redundant service stops
Remove the deploy-dev pre-task that stopped foreman.target before deployment - the roles should handle idempotent re-deploys. Remove the explicit postgresql stop from the upgrade path since postgresql is PartOf=foreman.target and stopping the target cascades to it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4f8862b commit c09f83c

2 files changed

Lines changed: 0 additions & 12 deletions

File tree

development/playbooks/deploy-dev/deploy-dev.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@
1515
- "../../../src/vars/foreman.yml"
1616
- "../../../src/vars/base.yaml"
1717
pre_tasks:
18-
- name: Stop foreman target
19-
ansible.builtin.systemd:
20-
name: foreman.target
21-
state: stopped
22-
failed_when: false
23-
2418
- name: Set development postgresql databases
2519
ansible.builtin.set_fact:
2620
postgresql_databases: >-

src/roles/postgresql/tasks/upgrade.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@
2727
state: stopped
2828
failed_when: false
2929

30-
- name: Stop postgresql service
31-
ansible.builtin.systemd:
32-
name: "{{ postgresql_container_name }}"
33-
state: stopped
34-
failed_when: false
35-
3630
- name: Wait for port 5432 to be completely freed by Podman
3731
ansible.builtin.wait_for:
3832
port: 5432

0 commit comments

Comments
 (0)