Move validate_features role to checks

Author: Arvind Jangir

src/filter_plugins/foremanctl.py

@@ -32,13 +32,7 @@ def known_foreman_plugins(_value):
 
 def invalid_features(features):
     """Return a list of unknown features not defined in features.yaml."""
-    unknown = []
-    for feature in features:
-        if feature in BASE_FEATURES:
-            continue
-        if feature not in FEATURE_MAP:
-            unknown.append(feature)
-    return unknown
+    return [feature for feature in features if feature not in FEATURE_MAP]
 
 class FilterModule(object):
     '''foremanctl filters'''

src/playbooks/deploy/deploy.yaml

@@ -14,7 +14,6 @@
     - "../../vars/base.yaml"
   roles:
     - role: pre_install
-    - role: validate_features
     - role: checks
     - role: certificates
       when: "certificate_source == 'default'"

src/roles/check_features/tasks/main.yaml

@@ -0,0 +1,15 @@
+---
+- name: Validate requested features
+  ansible.builtin.assert:
+    that:
+      - found_invalid_features | length == 0
+    fail_msg: |
+      ERROR: Unknown feature(s) requested: {{ found_invalid_features | join(', ') }}
+
+      To remove them, run:
+        foremanctl deploy {% for feature in found_invalid_features %}--remove-feature={{ feature }} {% endfor %}
+
+      Run 'foremanctl features' to list all available features.
+  vars:
+    found_invalid_features: "{{ features | invalid_features }}"
+  when: features | length > 0

src/roles/checks/tasks/main.yml

@@ -2,6 +2,7 @@
 - name: Execute checks
   ansible.builtin.include_tasks: execute_check.yml
   loop:
+    - check_features
     - check_hostname
     - check_database_connection
     - check_system_requirements